test: add cairo0 support to initialize_rpc_test_state #259
Conversation
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @Yael-Starkware)
crates/tests-integration/src/state_reader.rs line 130 at r1 (raw file):
cairo0_contract_classes: &mut Vec<(ClassHash, DeprecatedContractClass)>, cairo1_contract_classes: &mut Vec<(ClassHash, CasmContractClass)>, ) {
Consider constructing the vectors inside this function and return them in the return value.
Suggestion:
fn prepare_compiled_contract_classes(
contract_instances: &[(FeatureContract, u16)],
) -> (Vec<(ClassHash, DeprecatedContractClass)>, Vec<(ClassHash, CasmContractClass)>) {
Yael-Starkware
force-pushed
the
yael/add_cairo0_support_to_rpc_test_state
branch
from
6680dc2 to
3ddecb6
Compare
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @dafnamatsry)
crates/tests-integration/src/state_reader.rs line 130 at r1 (raw file):
Previously, dafnamatsry wrote…
Consider constructing the vectors inside this function and return them in the return value.
Done.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
=======================================
Coverage ? 80.98%
=======================================
Files ? 25
Lines ? 1152
Branches ? 1152
=======================================
Hits ? 933
Misses ? 170
Partials ? 49 ☔ View full report in Codecov by Sentry. |
Yael-Starkware
force-pushed
the
yael/add_cairo0_support_to_rpc_test_state
branch
from
3ddecb6 to
9f946d1
Compare
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @ArniStarkware and @dafnamatsry)
crates/tests-integration/src/state_reader.rs line 39 at r3 (raw file):
type ContractClassesMap = (Vec<(ClassHash, DeprecatedContractClass)>, Vec<(ClassHash, CasmContractClass)>);
Clippy made me add this.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @ArniStarkware)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)
This change is