feat(mempool): implement commit_block method #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohammadNassar1
force-pushed
the
mohammad/staging-area/add-staging-area
branch
from
bb6509b to
0ce25b9
Compare
MohammadNassar1
force-pushed
the
mohammad/mempool/implement-commit-block
branch
from
1c7a223 to
6c869fd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mohammad/staging-area/add-staging-area #197 +/- ##
==========================================================================
+ Coverage 83.70% 84.35% +0.64%
==========================================================================
Files 28 28
Lines 1381 1393 +12
Branches 1381 1393 +12
==========================================================================
+ Hits 1156 1175 +19
+ Misses 166 157 -9
- Partials 59 61 +2 ☔ View full report in Codecov by Sentry. |
MohammadNassar1
force-pushed
the
mohammad/staging-area/add-staging-area
branch
3 times, most recently
from
a3b6b1e to
d4c80f0
Compare
MohammadNassar1
force-pushed
the
mohammad/mempool/implement-commit-block
branch
3 times, most recently
from
a3cd33b to
0e55d71
Compare
MohammadNassar1
force-pushed
the
mohammad/staging-area/add-staging-area
branch
from
d4c80f0 to
2cc0064
Compare
MohammadNassar1
force-pushed
the
mohammad/mempool/implement-commit-block
branch
from
0e55d71 to
07898ea
Compare
MohammadNassar1
force-pushed
the
mohammad/staging-area/add-staging-area
branch
3 times, most recently
from
6282623 to
c9627dc
Compare
MohammadNassar1
force-pushed
the
mohammad/mempool/implement-commit-block
branch
from
07898ea to
b6b1810
Compare
MohammadNassar1
commented
Jul 2, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @ayeletstarkware, @elintul, and @giladchase)
a discussion (no related file):
On hold!
Please do not review it yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is