Skip to content

Commit

Permalink
chore: cleanup and extend todo comments
Browse files Browse the repository at this point in the history
commit-id:16da86a2
  • Loading branch information
Itay-Tsabary-Starkware committed Jun 6, 2024
1 parent 09712b6 commit 41a4675
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
2 changes: 2 additions & 0 deletions crates/mempool_infra/tests/common/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ use async_trait::async_trait;
type ValueA = u32;
type ValueB = u8;

// TODO(Tsabary): add more messages / functions to the components.

#[async_trait]
pub(crate) trait ComponentATrait: Send + Sync {
async fn a_get_value(&self) -> ValueA;
Expand Down
6 changes: 1 addition & 5 deletions crates/mempool_infra/tests/component_server_client_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,12 @@ impl ComponentA {
}
}

// todo find which of these derives is needed
// todo add more messages
// todo send messages from b to a
// TODO(Tsabary): send messages from component b to component a.

#[derive(Copy, Clone, Debug, PartialEq, Eq)]
pub enum ComponentARequest {
AGetValue,
}

#[derive(Copy, Clone, Debug, PartialEq, Eq)]
pub enum ComponentAResponse {
Value(ValueA),
}
Expand Down

0 comments on commit 41a4675

Please sign in to comment.