Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce gas usage of pow by about 15 percent. #7013

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Jan 7, 2025

No unrequired 0 checks.
Using accumulator argument to remove multiplication with known 1s.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

Copy link
Collaborator

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

@orizi orizi force-pushed the spr/main/7dbfdafe branch from cf0b4cd to efc0956 Compare January 7, 2025 09:10
@orizi orizi force-pushed the spr/main/e87af822 branch 2 times, most recently from 40f5194 to 84c8b68 Compare January 7, 2025 10:36
@orizi orizi changed the base branch from spr/main/7dbfdafe to main January 7, 2025 10:36
@orizi orizi enabled auto-merge January 7, 2025 10:38
No unrequired 0 checks.
Using accumulator argument to remove multiplication with known 1s.

commit-id:e87af822
@orizi orizi force-pushed the spr/main/e87af822 branch from 84c8b68 to c0bdd7f Compare January 7, 2025 11:40
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @gilbens-starkware)

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

@orizi orizi added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit cf06407 Jan 7, 2025
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants