Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed glob uses starting with non-explicit dep crates. #7011

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Jan 6, 2025

Considering starknet as a crate.

@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi enabled auto-merge January 6, 2025 15:59
@orizi orizi force-pushed the orizi/make-core-and-starknet-high-priority branch from afe91f3 to 9406dfd Compare January 6, 2025 16:01
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware and @TomerStarkware)


crates/cairo-lang-semantic/src/expr/semantic_test_data/use line 1390 at r1 (raw file):

)

//! > expected_diagnostics

prior to fix:

Suggestion:

//! > expected_diagnostics
error: Cycle detected while resolving 'use' items.
 --> lib.cairo:1:21
use core::starknet::*;
                    ^

crates/cairo-lang-semantic/src/expr/semantic_test_data/use line 1419 at r1 (raw file):

)

//! > expected_diagnostics

prior to fix:

Suggestion:

//! > expected_diagnostics
error: Identifier not found.
 --> lib.cairo:1:5
use starknet::*;
    ^^^^^^^^

Copy link
Collaborator

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @gilbens-starkware)

@orizi orizi added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 445314d Jan 7, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants