Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammatical errors #6962

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Fix grammatical errors #6962

merged 5 commits into from
Jan 7, 2025

Conversation

Marcofann
Copy link
Contributor

Files and Changes:

  1. destructs.rs

    • Corrected: "an where""and where" to fix grammatical inaccuracy and improve clarity.
  2. canonic.rs

    • Corrected: "a either""an either" to align with proper article usage before a word starting with a vowel sound.
  3. compute.rs

    • Corrected: "a ap-change""an ap-change" (twice) for proper article usage before words starting with a vowel sound.
  4. analyzer.rs

    • Corrected: "a enum""an enum" for proper article usage before words starting with a vowel sound.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Marcofann)


crates/cairo-lang-semantic/src/expr/inference/canonic.rs line 91 at r1 (raw file):

/// Mapping between canonical space and inference space.
/// Created by an either canonicalizing or embedding a trait.

Suggestion:

/// Created by either canonicalizing or embedding a trait.

@Marcofann
Copy link
Contributor Author

Hi @orizi

Thank you for the suggestion! I have made the requested changes:

  • Corrected the comment by removing the unnecessary "an" before "either", as suggested. The comment now reads:
    /// Created by either canonicalizing or embedding a trait.

Let me know if anything else is needed!

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Marcofann)

@orizi orizi enabled auto-merge January 7, 2025 10:49
@orizi orizi added this pull request to the merge queue Jan 7, 2025
Merged via the queue into starkware-libs:main with commit 76e5306 Jan 7, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants