Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved match tests for or patterns #4609

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Improved match tests for or patterns #4609

merged 1 commit into from
Dec 20, 2023

Conversation

yuvalsw
Copy link
Contributor

@yuvalsw yuvalsw commented Dec 19, 2023 •
edited by spapinistarkware
Loading

This change is Reviewable

@yuvalsw
Copy link
Contributor Author

yuvalsw commented Dec 19, 2023

change target branch

TomerStarkware
TomerStarkware approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

TomerStarkware
TomerStarkware approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion

orizi
orizi approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)

@yuvalsw yuvalsw changed the base branch from yuval/rename_semantic_diagnostics to main December 20, 2023 12:14
@yuvalsw yuvalsw force-pushed the yuval/improve_match_tests branch from 7c99b2c to 3d3eac9 Compare December 20, 2023 12:15
@yuvalsw yuvalsw enabled auto-merge December 20, 2023 12:15
@yuvalsw yuvalsw added this pull request to the merge queue Dec 20, 2023
Merged via the queue into main with commit d1f382e Dec 20, 2023
39 checks passed
@orizi orizi deleted the yuval/improve_match_tests branch December 21, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomerStarkware TomerStarkware TomerStarkware approved these changes

@orizi orizi orizi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuvalsw @orizi @TomerStarkware