Implement multiplication and addition operations for AffinePoint #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_affine_point Implement multiplication and addition operations for AffinePoint
FilipLaurentiu
requested review from
pefontana and
dan-starkware
as code owners
tdelabro
approved these changes
Jan 24, 2025
0xLucqs
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior?
Addition or multiplication not allowed for AffinePoint
What is the new behavior?
AffinePoints could now be added or multiplied by a scalar, similar with ProjectivePoint
Does this introduce a breaking change?
No
Other information
his is a new updated PR that was recently closed #112