upgrade to support dbt-core v1.7.0 #368
Conversation
damian3031
force-pushed
the
add-dbt-core-1.7.0-features
branch
from
054daba to
2645c8d
Compare
| """ | ||
|
|
||
|
|
||
| class TestDocsGenerateOverride: |
There was a problem hiding this comment.
is there a dbt test we could inherit from ?
There was a problem hiding this comment.
Unfortunately, not: dbt-labs/dbt-core#8307 (comment)
| {% if relation.schema and relation.identifier %} | ||
| ( | ||
| schema_name = '{{ relation.schema | lower }}' | ||
| and table_name = '{{ relation.identifier | lower }}' | ||
| ) | ||
| {% elif relation.schema %} | ||
| ( | ||
| schema_name = '{{ relation.schema | lower }}' | ||
| ) | ||
| {% else %} | ||
| {% do exceptions.raise_compiler_error( | ||
| '`get_catalog_relations` requires a list of relations, each with a schema' | ||
| ) %} | ||
| {% endif %} |
There was a problem hiding this comment.
are you testing all cases here? same for trino__get_catalog_schemas_where_clause_sql
There was a problem hiding this comment.
The only test from dbt-tests-adapter is TestDocsGenerateOverride. As mentioned in the comments, better tests are needed in dbt-tests-adapter, and dbt has committed to prioritizing their creation (here).
There was a problem hiding this comment.
so are we waiting for these tests before merging this PR?
There was a problem hiding this comment.
I don't think so, as they probably won't be added in final release 1.7.0, but rather in some patch release, hopefully in 1.7.1
damian3031
force-pushed
the
add-dbt-core-1.7.0-features
branch
from
2645c8d to
eab77d5
Compare
damian3031
changed the title
damian3031
force-pushed
the
add-dbt-core-1.7.0-features
branch
from
bea795f to
bfbd441
Compare
| ) %} | ||
| {% endif %} | ||
|
|
||
| {%- if not loop.last %} or {% endif -%} |
There was a problem hiding this comment.
note: the OR currently prevents Trino from optimizing these queries reasonably.
if this new code is a new to-be-common pattern in DBT, we may want to optimize information_schema.tables and information_schema.columns processing with this use-case in mind
resolves #361
get_catalogby object namedbt show, storing test failures as views, simple seed tests