Add file_format and table_format configurations

.changes/unreleased/Features-20241015-174143.yaml

@@ -0,0 +1,7 @@
+kind: Features
+body: Add file_format and table_format configurations
+time: 2024-10-15T17:41:43.584728+02:00
+custom:
+  Author: damian3031
+  Issue: ""
+  PR: "438"

dbt/include/trino/macros/adapters.sql

@@ -79,6 +79,39 @@
 
 {% macro properties() %}
   {%- set _properties = config.get('properties') -%}
+  {%- set table_format = config.get('table_format') -%}
+  {%- set file_format = config.get('file_format') -%}
+
+  {%- if file_format -%}
+    {%- if _properties -%}
+      {%- if _properties.format -%}
+        {% set msg %}
+          You can specify either 'file_format' or 'properties.format' configurations, but not both.
+        {% endset %}
+        {% do exceptions.raise_compiler_error(msg) %}
+      {%- else -%}
+        {%- do _properties.update({'format': file_format}) -%}
+      {%- endif -%}
+    {%- else -%}
+      {%- set _properties = {'format': file_format} -%}
+    {%- endif -%}
+  {%- endif -%}
+
+  {%- if table_format -%}
+    {%- if _properties -%}
+      {%- if _properties.type -%}
+        {% set msg %}
+          You can specify either 'table_format' or 'properties.type' configurations, but not both.
+        {% endset %}
+        {% do exceptions.raise_compiler_error(msg) %}
+      {%- else -%}
+        {%- do _properties.update({'type': table_format}) -%}
+      {%- endif -%}
+    {%- else -%}
+      {%- set _properties = {'type': table_format} -%}
+    {%- endif -%}
+  {%- endif -%}
+
   {%- if _properties is not none -%}
       WITH (
           {%- for key, value in _properties.items() -%}

tests/functional/adapter/test_table_properties.py

@@ -47,3 +47,119 @@ def test_table_properties(self, project):
         assert "WITH (" in logs
         assert "format = 'PARQUET'" in logs
         assert "format_version = 2" in logs
+
+
+@pytest.mark.iceberg
+class TestFileFormatConfig(BaseTableProperties):
+    # Configuration in dbt_project.yml
+    @pytest.fixture(scope="class")
+    def project_config_update(self):
+        return {
+            "name": "properties_test",
+            "models": {
+                "+materialized": "table",
+                "file_format": "'PARQUET'",
+            },
+        }
+
+    def test_table_properties(self, project):
+        # Seed seed
+        results = run_dbt(["seed"], expect_pass=True)
+        assert len(results) == 1
+
+        # Create model with properties
+        results, logs = run_dbt_and_capture(["--debug", "run"], expect_pass=True)
+        assert len(results) == 1
+        assert "WITH (" in logs
+        assert "format = 'PARQUET'" in logs
+
+
+@pytest.mark.iceberg
+class TestFileFormatConfigAndFormatTablePropertyFail(BaseTableProperties):
+    # Configuration in dbt_project.yml
+    @pytest.fixture(scope="class")
+    def project_config_update(self):
+        return {
+            "name": "properties_test",
+            "models": {
+                "+materialized": "table",
+                "+properties": {
+                    "format": "'PARQUET'",
+                },
+                "file_format": "'ORC'",
+            },
+        }
+
+    def test_table_properties(self, project):
+        # Seed seed
+        results = run_dbt(["seed"], expect_pass=True)
+        assert len(results) == 1
+
+        # Create model with properties
+        results, logs = run_dbt_and_capture(["--debug", "run"], expect_pass=False)
+        assert len(results) == 1
+        assert (
+            "You can specify either 'file_format' or 'properties.format' configurations, but not both."
+            in logs
+        )
+
+
+@pytest.mark.hive
+# Setting `type` property is available only in Starburst Galaxy
+# https://docs.starburst.io/starburst-galaxy/data-engineering/working-with-data-lakes/table-formats/gl-iceberg.html
+@pytest.mark.skip_profile("trino_starburst")
+class TestTableFormatConfig(BaseTableProperties):
+    # Configuration in dbt_project.yml
+    @pytest.fixture(scope="class")
+    def project_config_update(self):
+        return {
+            "name": "properties_test",
+            "models": {
+                "+materialized": "table",
+                "table_format": "'iceberg'",
+            },
+        }
+
+    def test_table_properties(self, project):
+        # Seed seed
+        results = run_dbt(["seed"], expect_pass=True)
+        assert len(results) == 1
+
+        # Create model with properties
+        results, logs = run_dbt_and_capture(["--debug", "run"], expect_pass=True)
+        assert len(results) == 1
+        assert "WITH (" in logs
+        assert "type = 'iceberg'" in logs
+
+
+@pytest.mark.hive
+# Setting `type` property is available only in Starburst Galaxy
+# https://docs.starburst.io/starburst-galaxy/data-engineering/working-with-data-lakes/table-formats/gl-iceberg.html
+@pytest.mark.skip_profile("trino_starburst")
+class TestTableFormatConfigAndTypeTablePropertyFail(BaseTableProperties):
+    # Configuration in dbt_project.yml
+    @pytest.fixture(scope="class")
+    def project_config_update(self):
+        return {
+            "name": "properties_test",
+            "models": {
+                "+materialized": "table",
+                "+properties": {
+                    "type": "'iceberg'",
+                },
+                "table_format": "'iceberg'",
+            },
+        }
+
+    def test_table_properties(self, project):
+        # Seed seed
+        results = run_dbt(["seed"], expect_pass=True)
+        assert len(results) == 1
+
+        # Create model with properties
+        results, logs = run_dbt_and_capture(["--debug", "run"], expect_pass=False)
+        assert len(results) == 1
+        assert (
+            "You can specify either 'table_format' or 'properties.type' configurations, but not both."
+            in logs
+        )