Zeros out the dead zones in the TPC #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which couldn't possibly cause any side effects, but lets be safe about it shall we?)
genevb
reviewed
Jan 15, 2025
|
This is a shift of responsibility of simulating hits in the deadzone from the geant simulation to the slow simulator. So I think any versioning scheme would need to apply to both. Absent that... We have to be careful when back porting into embedding libraries. The slow simulator and TPC geometry must be consistent with each other. |
genevb
approved these changes
Jan 15, 2025
|
TpcRS took over for Gating Grid dead region accounting via StRoot/StdEdxY2Maker/StTpcdEdxCorrection in PR |
fisyak
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deadzone in the TPC. Responsibility for simulating the deadzone is then shifted to the gating grid simulation.
This PR impacts all geometry tags that use the TpceGeo3a, 4, 5(*) and 6 models.
This PR should be tested prior to merging. Note that this implementation would have the following consequences...
... the correct version of the TPC slow simulator must be used from this point forward ...
... any backport of the tpc geometry into an earlier embedding library requires backport of the slow simulator and vice versa ...
Should have a discussion about this before mergeing.
(*) No tag uses the TpceGeo5 model. Listed here for completeness.