Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clock jump calibration #711

Merged
merged 60 commits into from
Oct 17, 2024
Merged

Clock jump calibration #711

merged 60 commits into from
Oct 17, 2024

Conversation

YannickSoehngen
Copy link
Contributor

Methods for retrieving get4 state from db and flagging calibrated hits

Yannick Soehngen and others added 30 commits December 5, 2022 13:49
ClockJump_correction update and new method for Hit manipulation on co…
9a72c75 
…unter level
added missing etofHelperFunctions
9889653
addressed suggested changes
ffa9088
@plexoos
Merge branch 'main' into ClockJumpCorrection-and-CounterMod-update
febf3f7
@plexoos
Merge branch 'main' into ClockJumpCorrection-and-CounterMod-update
c62c0a9
2nd round of comments
8551432
Merge branch 'ClockJumpCorrection-and-CounterMod-update' of https://g…
0923a14 
…ithub.com/YannickSoehngen/star-sw into ClockJumpCorrection-and-CounterMod-update
@plexoos
change white space
b9dcf39
3d round of comments
7cd0372
Merge branch 'ClockJumpCorrection-and-CounterMod-update' of https://g…
fa5e2c5 
…ithub.com/YannickSoehngen/star-sw into ClockJumpCorrection-and-CounterMod-update
4th round of comments
9a8fd38
@plexoos
Merge branch 'main' into ClockJumpCorrection-and-CounterMod-update
a38037f
5th round of comments
eda3e89
Merge branch 'ClockJumpCorrection-and-CounterMod-update' of https://g…
e10c291 
…ithub.com/YannickSoehngen/star-sw into ClockJumpCorrection-and-CounterMod-update
bug fix in HitMaker
79f22f2
@plexoos
Clean up white space according to coding guidelines
ef9e5b6
@plexoos
remove undefined class method
98f1101
@plexoos
Revert "bug fix in HitMaker"
7139608 
This reverts commit 79f22f2.
@plexoos
Tweak StETofGeometry::init() default params
fa6331e
renamed variables and replaced 6.25 by etofConstant
4c77e07
Merge branch 'ClockJumpCorrection-and-CounterMod-update' of https://g…
591ab4e 
…ithub.com/YannickSoehngen/star-sw into ClockJumpCorrection-and-CounterMod-update
removed unused variable
9e25945
adjusted default electronics dead-time
b9b1559
Merge remote-tracking branch 'origin' into MaskCountersForProduction
63f2ad4
add set method in MatchMaker, fix HitMaker for masking counters
fdd2424
fixed PulserCorrection, added set method for AfterpulseCorrection
84cd1e5
StatusFlag Fix and implementation of SingleSidedMatches
e5e1adf
incremented ClassDef
a86d3ad
@plexoos
Merge branch 'main' into MatchUpdate-and-EventFlagFix
b7b6d86
removed unnecessary if statement
32cb6b6
plexoos
plexoos reviewed Sep 23, 2024
View reviewed changes
StRoot/StETofCalibMaker/StETofCalibMaker.cxx Outdated Show resolved Hide resolved
StRoot/StETofCalibMaker/StETofCalibMaker.cxx Outdated Show resolved Hide resolved
StRoot/StETofMatchMaker/StETofMatchMaker.h Outdated Show resolved Hide resolved
StRoot/StETofCalibMaker/StETofCalibMaker.cxx Outdated Show resolved Hide resolved
StRoot/StETofCalibMaker/StETofCalibMaker.cxx Outdated Show resolved Hide resolved
StRoot/StETofCalibMaker/StETofCalibMaker.cxx Outdated Show resolved Hide resolved
StRoot/StETofCalibMaker/StETofCalibMaker.cxx Outdated Show resolved Hide resolved
StRoot/StETofCalibMaker/StETofCalibMaker.h Outdated Show resolved Hide resolved
StRoot/StETofCalibMaker/StETofCalibMaker.cxx Outdated Show resolved Hide resolved
genevb and others added 11 commits September 23, 2024 11:33
@plexoos
Copy link
Member

plexoos commented Oct 2, 2024

@YannickSoehngen, I noticed the code is failing the CI build. Do you understand the compiler error?

541.2 g++ -m64 -fPIC -pipe -Wall -Woverloaded-virtual -std=c++0x -Wno-long-long -pthread -Wno-deprecated-declarations -Werror -O2 -g -falign-loops -falign-jumps -falign-functions -Dsl79_gcc485 -D__ROOT__ -DNEW_DAQ_READER -I. -IStRoot -I.sl79_gcc485/include -I/opt/software/linux-scientific7-x86_64/gcc-4.8.5/root-5.34.38-ffhsnriu5ktoo4tieuku5tbezanz6q5g/include -c .sl79_gcc485/OBJ/StRoot/StETofCalibMaker/StETofCalibMaker.cxx -o .sl79_gcc485/OBJ/StRoot/StETofCalibMaker/StETofCalibMaker.o
541.3 .sl79_gcc485/OBJ/StRoot/StETofCalibMaker/StETofCalibMaker.cxx:83:46: fatal error: tables/St_etofGet4StateMap_Table.h: No such file or directory
541.3  #include "tables/St_etofGet4StateMap_Table.h"

@plexoos
Copy link
Member

plexoos commented Oct 2, 2024

Do we need the change in #712 to fix this?

@genevb genevb mentioned this pull request Oct 2, 2024
Merged
@plexoos
Copy link
Member

plexoos commented Oct 4, 2024

Thanks for the suggestion, Gene! It looks like the new table is now being ignored when processing older datasets.

@fgeurts
Copy link
Member

fgeurts commented Oct 8, 2024

Is there any news on this PR? Can the assigned reviewers (@nigmatkulov @jdbrice @marrbnl @PhilippWeidenkaff) approve it so we can go ahead with the merger.

@fgeurts fgeurts self-assigned this Oct 16, 2024
@fgeurts fgeurts self-requested a review October 16, 2024 01:13
fgeurts
fgeurts approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@fgeurts fgeurts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the discussions during last week's S&C meeting, this PR should be approved and move forward for merger.

@YannickSoehngen YannickSoehngen merged commit 3271996 into star-bnl:main Oct 17, 2024
148 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genevb genevb genevb left review comments

@klendathu2k klendathu2k klendathu2k left review comments

@fgeurts fgeurts fgeurts approved these changes

@plexoos plexoos plexoos approved these changes

@nigmatkulov nigmatkulov Awaiting requested review from nigmatkulov

@marrbnl marrbnl Awaiting requested review from marrbnl

@jdbrice jdbrice Awaiting requested review from jdbrice

@PhilippWeidenkaff PhilippWeidenkaff Awaiting requested review from PhilippWeidenkaff PhilippWeidenkaff is a code owner

Assignees

@fgeurts fgeurts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@YannickSoehngen @plexoos @fgeurts @klendathu2k @genevb