Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unresponsive reviewers from CODEOWNERS #691

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

plexoos
Copy link
Member

@plexoos plexoos commented Jun 26, 2024

As discussed, we've cleaned up the CODEOWNERS file by removing unresponsive or inactive members.

@plexoos plexoos requested a review from veprbl as a code owner June 26, 2024 17:35
@plexoos
Copy link
Member Author

plexoos commented Jun 26, 2024

Feel free to submit your suggestions or commit to this branch directly before it's merged.

@plexoos
Copy link
Member Author

plexoos commented Jun 26, 2024

Frank, was it you who added ZaochenYe? There is no such github user

@plexoos
Copy link
Member Author

plexoos commented Jun 26, 2024

Also, I don't think @ideppner has ever accepted the invitation to the star-bnl organization. Should be removed?

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
@fgeurts
Copy link
Member

fgeurts commented Jun 26, 2024

@rkunnawa is not in STAR anymore. I am not sure who @zhux97. Cannot find a profile on GitHub.

@fgeurts
Copy link
Member

fgeurts commented Jun 26, 2024

Frank, was it you who added ZaochenYe? There is no such github user

Zaochen's GitHub ID is @Morning-Ye

@starsdong
Copy link
Member

@rkunnawa is not in STAR anymore. I am not sure who @zhux97. Cannot find a profile on GitHub.

@zhux97 is Xianglei Zhu.

Copy link
Contributor

@genevb genevb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are fine with me, though Victor may still appreciate being informed of code changes even if he isn't actively reviewing anything. One could ask him before dropping him.

@plexoos
Copy link
Member Author

plexoos commented Jun 26, 2024

I'm fine with keeping anyone who is willing to own the code and monitor changes in the CODEOWNERS file. My understanding was that the goal was to reduce the list of automatically requested reviewers to streamline the approval process and speed up merging. If someone wants to be notified about specific activities, they can adjust their notification settings or star the repository. More details can be found here: GitHub Notification Settings.

@fgeurts
Copy link
Member

fgeurts commented Jun 26, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants