Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete warinings BTofSimMaker.cxx #675

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Delete warinings BTofSimMaker.cxx #675

merged 4 commits into from
Mar 27, 2024

Conversation

DanielTorres98
Copy link
Contributor

This branch is to address mentioned here: Issue 149

@plexoos
Copy link
Member

plexoos commented Mar 26, 2024

Thank you Daniel for addressing the warnings in StBTofSimMaker! As a formal test and to confirm that all is as expected, I am removing it from the list of packages with skipped warnings-as-errors checks.

klendathu2k
klendathu2k approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@klendathu2k klendathu2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these changes just make sure everything is initialized, and removes unused variables. Compilation should be sufficient test that this is correct.

genevb
genevb reviewed Mar 26, 2024
View reviewed changes
Copy link
Contributor

@genevb genevb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection to the mgr/ change from me.

plexoos
plexoos approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@plexoos plexoos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build logs look clean now with respect to warnings in StBTofSimMaker

@plexoos plexoos merged commit 2e60a9d into main Mar 27, 2024
148 checks passed
@plexoos plexoos deleted the Delete_warining_BTOF_sim_maker branch March 27, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genevb genevb genevb left review comments

@klendathu2k klendathu2k klendathu2k approved these changes

@plexoos plexoos plexoos approved these changes

@Morning-Ye Morning-Ye Awaiting requested review from Morning-Ye

@darkmatterist darkmatterist Awaiting requested review from darkmatterist

@fgeurts fgeurts Awaiting requested review from fgeurts fgeurts is a code owner

@starsdong starsdong Awaiting requested review from starsdong

@jdbrice jdbrice Awaiting requested review from jdbrice jdbrice is a code owner

@fisyak fisyak Awaiting requested review from fisyak fisyak is a code owner

@R-Witt R-Witt Awaiting requested review from R-Witt R-Witt is a code owner

@iraklic iraklic Awaiting requested review from iraklic iraklic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanielTorres98 @plexoos @klendathu2k @genevb