Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper dependencies for FCS Pi0 used in QA #669

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Proper dependencies for FCS Pi0 used in QA #669

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6f08df
Proper dependencies for FCS Pi0 used in QA
genevb Mar 20, 2024
3faae9a
Merge branch 'main' into QA_FCS
genevb Mar 20, 2024
2ec9cc9
Merge branch 'main' into QA_FCS
genevb Mar 26, 2024
a0b4b41
Merge branch 'star-bnl:main' into QA_FCS
genevb Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion StRoot/StBFChain/BigFullChain.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1639,6 +1639,7 @@ Bfc_st BFC[] = { // standard chains
"StFcsClusterMaker","StFcsClusterMaker","Fill FCS clusters", kFALSE},
{"fcsPoint" ,"","fcsChain", "StEvent,fcsDb",
"StFcsPointMaker","StFcsPointMaker,libMinuit","Fill FCS points", kFALSE},
{"fcsPi0Libs","", "", "MuDst", "", "StFcsPi0FinderForEcal", "Libs for FCS Pi0 Finder", kFALSE},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FCS pi0 finder uses the MuDst for input rather than StEvent.

Copy link
Contributor Author

@genevb genevb Mar 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems an odd mix of MuDst and StEvent: it appears to require StEvent for its Make() member function, but then may call some MuDst static functions later in that member function. It's likely that these dependencies can be further reduced/improved, but for now I'm trying to ensure St_QA_Maker's dependencies, as that's my responsibility.

// FTT
{"ftt","fttChain","","FttDat,FttHitCalib,FttClu,FttPoint", "StMaker","StChain","FST chain" ,kFALSE},
{"FttDat","","fttChain","StEvent","StFttRawHitMaker","StFttRawHitMaker,StEvent",
Expand Down Expand Up @@ -1922,7 +1923,8 @@ Bfc_st BFC[] = { // standard chains
{"ppDAQfilter1","","","" ,"","",STAR_CHAIN_OBSOLETE,kFALSE},
{"ppLPeval1" ,"","","" ,"","",STAR_CHAIN_OBSOLETE,kFALSE},
{"QA" ,"","","" ,"","",STAR_CHAIN_OBSOLETE,kFALSE},
{"EventQA","EventQA","","QUtils,Event","StEventQAMaker" ,"St_QA_Maker","Filling Y2/Y3 Qa histo",kFALSE},
{"EventQA","EventQA","","QUtils,Event,fcsPi0Libs","StEventQAMaker"
,"St_QA_Maker","Filling Y2/Y3 Qa histo",kFALSE},
{"QAC" ,"CosmicsQA","globT","" ,"StQACosmicMaker","StQACosmicMaker","",kFALSE},
{"QAalltrigs" ,"", "","", "","","Analyze all triggers in QA",kFALSE},
{"HitFilt" ,"", "","", "StHitFilterMaker","StHitFilterMaker","Hit filter Maker",kFALSE},
Expand Down
4 changes: 1 addition & 3 deletions StRoot/St_QA_Maker/StEventQAMaker.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,7 @@
#include "StEpdCollection.h"

//fcs
#define SKIPDefImp
#include "StFcsPi0FinderForEcal/StFcsPi0FinderForEcal.cxx"
#undef SKIPDefImp
#include "StFcsPi0FinderForEcal/StFcsPi0FinderForEcal.h"

#include "StEvent/StTpcRawData.h"

Expand Down
Loading