Vpd start mode integrated #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please check error in compilation: 'class StVpdSimConfig' has no member named 'singleTGubeRes' |
|
looks good to me |
|
Thanks for addressing my earlier comment. |
|
You need to update the branch which appears to be out-of-date with the base branch |
fgeurts
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
StBTofCalibMaker::tofCellResolution function can now use VPD start resolution if UseVpdStart is set to TRUE.
Additionally, singleTubeRes was fixed to compute the VPD resolution correctly based on which tubes were used.