Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: do not inline map accessor #641

Merged
merged 1 commit into from
Jan 31, 2024
Merged

refactor: do not inline map accessor #641

merged 1 commit into from
Jan 31, 2024

Conversation

plexoos
Copy link
Member

@plexoos plexoos commented Jan 31, 2024

Resolves #620

klendathu2k
klendathu2k approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@klendathu2k klendathu2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfectly reasonable for these functions to be not inlined, and should have zero impact on the geometry model.

@genevb genevb removed their request for review January 31, 2024 15:43
@plexoos plexoos merged commit d966bc2 into star-bnl:main Jan 31, 2024
148 checks passed
@plexoos plexoos deleted the fix_agml branch January 31, 2024 23:17
dkapukchyan pushed a commit to dkapukchyan/star-sw that referenced this pull request Mar 11, 2024
@plexoos @klendathu2k @dkapukchyan
refactor: do not inline map accessor (star-bnl#641)
f3d92de 
Resolves star-bnl#620

Co-authored-by: klendathu2k <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klendathu2k klendathu2k klendathu2k approved these changes

@fisyak fisyak Awaiting requested review from fisyak fisyak is a code owner

@R-Witt R-Witt Awaiting requested review from R-Witt R-Witt is a code owner

@iraklic iraklic Awaiting requested review from iraklic iraklic is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime errors in StarVMC/StarAgmlLib when using ROOT 6.24
2 participants
@plexoos @klendathu2k