Fix job crashing for 9 time-bin FST data #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @techuan-huang . Two notes from me:
-Gene |
plexoos
approved these changes
Dec 8, 2023
jdbrice
approved these changes
Dec 8, 2023
techuan-huang
changed the title
|
Are we waiting for @akioogawa 's approval, or can this be merged now? |
plexoos
pushed a commit
that referenced
this pull request
Dec 13, 2023
Issue #631 was due to an inconsistent number of time bins used in the data and the codes. In most FST data and in the codes, we used 3 time bins, while some data used 9 time bins. Only changing a constant in `StRoot/StEvent/StFstConsts.h` is needed to fix this issue. Co-authored-by: Te-Chuan Huang <[email protected]>
dkapukchyan
pushed a commit
to dkapukchyan/star-sw
that referenced
this pull request
Mar 11, 2024
Issue star-bnl#631 was due to an inconsistent number of time bins used in the data and the codes. In most FST data and in the codes, we used 3 time bins, while some data used 9 time bins. Only changing a constant in `StRoot/StEvent/StFstConsts.h` is needed to fix this issue. Co-authored-by: Te-Chuan Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #631 was due to an inconsistent number of time bins used in the data and the codes.
In most FST data and in the codes, we used 3 time bins, while some data used 9 time bins.
Only changing a constant in
StRoot/StEvent/StFstConsts.his needed to fix this issue.