Hide AgML library codes from the macros which load the geometry. #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ible fix for issue star-bnl#620.
klendathu2k
requested review from
genevb,
fisyak,
R-Witt,
iraklic and
plexoos
as code owners
|
All tests succeeded. Syncing with main and changing from draft to normal PR. |
klendathu2k
commented
Nov 3, 2023
| @@ -2,8 +2,6 @@ | |||
|
|
|||
| #if !defined(__CINT__) || defined(__CLING__) | |||
| #include "StBFChain/StBFChain.h" | |||
| #include "StarVMC/StarAgmlLib/AgModule.h" | |||
There was a problem hiding this comment.
Probable culprit for the test failures. The AgML library codes are overly complex... especially the shape and structure handling codes. Would not be surprise if cling doesn't handle them well...
iraklic
approved these changes
Nov 3, 2023
|
I've applied this patch to #619 but there are still errors. However, this PR passed the existing test so, I am OK merging it |
plexoos
approved these changes
Nov 8, 2023
dkapukchyan
pushed a commit
to dkapukchyan/star-sw
that referenced
this pull request
Mar 11, 2024
…r-bnl#623) Possible fix for issue star-bnl#620.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for issue #620.