[Geometry/y2024] First cut (and first production cut) of the y2024 geometry model #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ometry model. Ident to y2023... STAR has reached a point of stability in its evolution...
klendathu2k
requested review from
perevbnlgov,
fisyak,
R-Witt and
iraklic
as code owners
plexoos
approved these changes
Nov 3, 2023
iraklic
approved these changes
Nov 3, 2023
dkapukchyan
pushed a commit
to dkapukchyan/star-sw
that referenced
this pull request
Mar 11, 2024
…ometry model (star-bnl#622) Ident to y2023... STAR has reached a point of stability in its evolution...
genevb
reviewed
Mar 20, 2024
| @@ -162,6 +162,9 @@ static const DbAlias_t fDbAlias[] = {// geometry Comment old | |||
| { "y2023", 20230410, 0, "y2023", "y2023 first cut geometry, AgML,xgeometry"}, | |||
| { "y2023a", 20230410, 1, "y2023a", "y2023a production geometry, AgML,xgeometry"}, | |||
|
|
|||
| { "y2023", 20231210, 0, "y2024", "y2024 first cut geometry, AgML,xgeometry"}, | |||
| { "y2023a", 20231210, 1, "y2024a", "y2024a production geometry, AgML,xgeometry"}, | |||
There was a problem hiding this comment.
Looks like this was a typo.... Should be y2024 and y2024a, yes?
|
Fixed w/ PR #670.
…On 2024-03-20 00:06, Gene Van Buren wrote:
@genevb commented on this pull request.
-------------------------
In StRoot/StChain/GeometryDbAliases.h [1]:
> @@ -162,6 +162,9 @@ static const DbAlias_t fDbAlias[] = {// geometry
Comment old
{ "y2023", 20230410, 0, "y2023", "y2023 first cut
geometry, AgML,xgeometry"},
{ "y2023a", 20230410, 1, "y2023a", "y2023a production
geometry, AgML,xgeometry"},
+ { "y2023", 20231210, 0, "y2024", "y2024 first cut
geometry, AgML,xgeometry"},
+ { "y2023a", 20231210, 1, "y2024a", "y2024a production
geometry, AgML,xgeometry"},
Looks like this was a typo.... Should be y2024 and y2024a, yes?
--
Reply to this email directly, view it on GitHub [2], or unsubscribe
[3].
You are receiving this because you modified the open/close
state.Message ID:
***@***.***>
Links:
------
[1] #622 (comment)
[2]
#622 (review)
[3]
https://github.com/notifications/unsubscribe-auth/ANL4LVFRKQBLWSRIVBOJ4NTYZEDN3AVCNFSM6AAAAAA63HNXG6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSNBXHEYTCMBZGA
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ident to y2023... STAR has reached a point of stability in its evolution...