Geant4 BFC options #613
Merged
Geant4 BFC options #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... collapse some of these options together ... remove options which are not likely to be used (we can always add them back if needed).
klendathu2k
requested review from
genevb,
fisyak,
R-Witt,
iraklic and
plexoos
as code owners
|
Not quite ready for prime time... seems to break several tests. Investigating. |
klendathu2k
force-pushed
the
geant4-bfc-integration
branch
from
7028d8f to
28599e1
Compare
|
In order to test functionality, need to load G4 modules via |
plexoos
reviewed
Oct 26, 2023
plexoos
approved these changes
Oct 26, 2023
|
Any thoughts as to why the whitespace in BigFullChain.h was causing runtime errors? |
|
The white space change was used to trigger CI. There was a small adjustment in the container environment |
|
And... we merge. |
dkapukchyan
pushed a commit
to dkapukchyan/star-sw
that referenced
this pull request
Mar 11, 2024
Adding BFC options to load geant4 libraries. --------- Co-authored-by: Dmitri Smirnov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding BFC options to load geant4 libraries, and load the relevant spack modules to support. (The latter is better added to the star-env modules?)