Fix memory leak in StFstClusterMaker #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techuan-huang
requested review from
jdbrice,
sunxuhit and
yezhenyu2003
as code owners
genevb
reviewed
Oct 2, 2023
There was a problem hiding this comment.
This patch has resolved the significant increase in reconstruction time per event over the course of processing files that I observed and documented when including FWD chain options. I'm very happy to see that!
jdbrice
approved these changes
Oct 6, 2023
plexoos
approved these changes
Oct 6, 2023
dkapukchyan
pushed a commit
to dkapukchyan/star-sw
that referenced
this pull request
Mar 11, 2024
Memory leaks were found by Gene in issue star-bnl#590. There are 3 places causing the leak in `StFstClusterMaker/StFstScanRadiusClusterAlgo.cxx`: 1. Pointers assigned to std::vector in `line 55` were not deleted before calling std::vector::pop_back() in `line 69` and `line 80`. 2. Object created in `line 140` but only conditionally assigned to a std::vector in `line 148`. 3. In `line 203`, std::vector::erase() was called without deleting the pointers. After fixing these places, there is no memory leak from StFstClusterMaker reported by valgrind. --------- Co-authored-by: Dmitri Smirnov <[email protected]> Co-authored-by: Te-Chuan Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory leaks were found by Gene in issue #590.
There are 3 places causing the leak in
StFstClusterMaker/StFstScanRadiusClusterAlgo.cxx:line 55were not deleted before calling std::vector::pop_back() inline 69andline 80.line 140but only conditionally assigned to a std::vector inline 148.line 203, std::vector::erase() was called without deleting the pointers.After fixing these places, there is no memory leak from StFstClusterMaker reported by valgrind.