Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starsim bfc tests #570

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Starsim bfc tests #570

wants to merge 10 commits into from

Conversation

klendathu2k
Copy link
Contributor

Add three tests which exercise starsim via St_geant_Maker. Duration of the tests is quick O(2min).

plexoos
plexoos reviewed Jul 25, 2023
View reviewed changes
tests/joblist.json Outdated Show resolved Hide resolved
tests/executest.py Outdated Show resolved Hide resolved
plexoos
plexoos previously approved these changes Jul 28, 2023
View reviewed changes
@plexoos
Copy link
Member

plexoos commented Jul 28, 2023

In order to include these test in CI we need to:

  1. add them to the workflow

    star-sw/.github/workflows/build-pull-request.yml

    Line 50 in c677c84

    test_id: [10, 11, 22, 23, 24, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 59, 60, 76, 77, 78, 90, 91, 92, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125]
  2. provide the generator libraries from https://github.com/star-bnl/star-mcgen

@plexoos plexoos requested a review from veprbl as a code owner July 28, 2023 16:36
@plexoos
Copy link
Member

plexoos commented Jul 28, 2023 •
edited
Loading

Wait.. what? They did not fail... but how can this bfc.C(50, "sdt20230214 pythia") work without Pythia?
The output is likely all empty events:

 QA :INFO  - QAInfo: Done with Event [no. 48/run 1/evt. 48/Date.Time 20230214.0/sta 3] Real Time =       0.00 seconds Cpu Time =        0.00 seconds
QA :INFO  - QAInfo: Cpu Times: user / system / user children / system children =     0.00 /     0.00 /     0.00 /     0.00 seconds (tick =   100.00, cps = 1000000)
QA :INFO  - QAInfo: Cpu Times: all threads =     0.000182500 seconds
St_geant_Maker:INFO  - *** St_geant_Maker::Make() == StERR(3) ***
QA :INFO  - QAInfo: Done with Event [no. 49/run 1/evt. 49/Date.Time 20230214.0/sta 3] Real Time =       0.00 seconds Cpu Time =        0.00 seconds
QA :INFO  - QAInfo: Cpu Times: user / system / user children / system children =     0.00 /     0.00 /     0.00 /     0.00 seconds (tick =   100.00, cps = 1000000)
QA :INFO  - QAInfo: Cpu Times: all threads =     0.000164600 seconds
St_geant_Maker:INFO  - *** St_geant_Maker::Make() == StERR(3) ***
QA :INFO  - QAInfo: Done with Event [no. 50/run 1/evt. 50/Date.Time 20230214.0/sta 3] Real Time =       0.00 seconds Cpu Time =        0.00 seconds
QA :INFO  - QAInfo: Cpu Times: user / system / user children / system children =     0.00 /     0.00 /     0.00 /     0.00 seconds (tick =   100.00, cps = 1000000)
QA :INFO  - QAInfo: Cpu Times: all threads =     0.000176900 seconds
QA :INFO  - QAInfo:EventLoop completed code 3

StERR(3) does not mean anything good I assume

@plexoos
Copy link
Member

plexoos commented Jul 28, 2023 

QA :INFO  - QAInfo:St_geant_Maker       built Jul 28 2023 17:47:16 from Tag $Name:  $ $Id: St_geant_Maker.h,v 1.60 2020/02/26 21:26:20 jwebb Exp $ 
 calling aginit 
 ******************************************************
 * Starting  starsim NwGEANT=  10000000 NwPAW=       0 *
 **********************pid=    69**********************
 ******************************************************
 *                                                    *
 *            W E L C O M E    to   starsim           *
 *                                                    *
 *        Version INITIAL     28 July 2023            *
 *                                                    *
 ******************************************************
 Version 1.29/04 of HIGZ started
 CSINIT: CERNLIB_STDUNIX
 CSINIT: CERNLIB_UNIX
1*****  GEANT Version  3.21/08 Released on 230697
0*****  Correction Cradle Version  0.0800
 *****  RZMAKE. OLD RZ format selected for RZDOC               
  Events will not be splitted into subevents 
StChain:INFO  - TAttr::Found : pythia = 1

 *** Unknown routine or function ---> bpythia
 *** Unknown command: MDCY
 *** Unknown command: MDCY
 *** Unknown command: MDCY
 *** Unknown command: MDCY
 *** Unknown command: MDCY
 *** Unknown command: MDCY
 *** Unknown command: MDCY
 *** Unknown command: MDCY
 *** Unknown command: MDCY
 *** Unknown command: MDCY
 *** Unknown command: MDCY
 *** Unknown command: MDCY
 *** Unknown command: MDCY
 *** Unknown command: frame
 *** Unknown command: beam
 *** Unknown command: ener
 *** Unknown routine or function ---> PyTUNE
 *** Unknown routine or function ---> pystat

@plexoos plexoos added the tests Changes affecting our automatic tests label Aug 2, 2023
@klendathu2k
Copy link
Contributor Author

Just coming back to this topic. The point of this pull request is to test the frameworks for event generation, rather than testing individual event generators. So in my next commit I will remove the falsely-passing tests and commit the test that I am really interested in... a test of StarGenerator. That test will ensure that I don't make any code-breaking commits as I integrate the geant4 maker.

@star-bnl star-bnl deleted a comment from dmixsmi Aug 10, 2023
@klendathu2k
Remove filter dependence from stargen, and define a stargen.filt bfc …
6071c80 
…option to load it separately
@klendathu2k
Setup the StarKinematics event generator to throw particles flat in pt,
b8b9b89 
eta and phi according to attributes set on the maker.  Add option to BFC
to throw 80 muons flat in pt, eta and phi.  The intent is to provide an
integration test of the StarGenerator framework.

---

Throw particles flat in phase space if appropriate attributes set on the generator.

Add option to throw a flat distribution of particles using StarGenerator, analagous to the "gstar" option.

On genmuons, instantiate the StarPrimaryMaker.  Add kinematics generator.  Setup for 80 muons flat in pt,eta and phi.

Add CI test for StarGenerator
@klendathu2k
Copy link
Contributor Author

Note... 1 test fails (128) b/c it is no longer defined (and I am unable to remove the test from the workflow due to lack of permission).

@iraklic
Copy link
Member

iraklic commented Aug 11, 2023

There is 128 in test_id does corresponding jobid need to exist in the json file or that is a placeholder?

@plexoos
Copy link
Member

plexoos commented Aug 11, 2023

Note... 1 test fails (128) b/c it is no longer defined (and I am unable to remove the test from the workflow due to lack of permission).

What lack of permission? You should be able to modify .github/workflows/build-pull-request.yml like anyone else with write permission to this repo. I just checked; job 128 was included because you had it in the initial commit on this branch, 2c7f059. However, it was somehow removed in the subsequent commits.

    {
        "jobid": "128",
        "descr": "2023 hijing simulation",
        "chopts": "sdt20230214 hijing",
        "inpfile": "",
        "inppath": "",
        "outpath": "",
        "nevents": "50"
    }

@iraklic
Copy link
Member

iraklic commented Aug 11, 2023

Note... 1 test fails (128) b/c it is no longer defined (and I am unable to remove the test from the workflow due to lack of permission).

What lack of permission? You should be able to modify .github/workflows/build-pull-request.yml like anyone else with write permission to this repo. I just checked; job 128 was included because you had it in the initial commit on this branch, 2c7f059. However, it was somehow removed in the subsequent commits.

    {
        "jobid": "128",
        "descr": "2023 hijing simulation",
        "chopts": "sdt20230214 hijing",
        "inpfile": "",
        "inppath": "",
        "outpath": "",
        "nevents": "50"
    }

ah, thanks for checking. So @klendathu2k do you want to bring that job back or the commit is ok as it is? Let me know, I can go ahead and approve it

@plexoos plexoos dismissed their stale review September 27, 2023 16:39

changes after it's been reviewed, non-existing test job is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plexoos plexoos plexoos left review comments

@nigmatkulov nigmatkulov Awaiting requested review from nigmatkulov nigmatkulov is a code owner

@veprbl veprbl Awaiting requested review from veprbl veprbl is a code owner

@perevbnlgov perevbnlgov Awaiting requested review from perevbnlgov

@genevb genevb Awaiting requested review from genevb genevb is a code owner

@fisyak fisyak Awaiting requested review from fisyak fisyak is a code owner

@R-Witt R-Witt Awaiting requested review from R-Witt R-Witt is a code owner

@iraklic iraklic Awaiting requested review from iraklic iraklic is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
tests Changes affecting our automatic tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klendathu2k @plexoos @iraklic