[root6] Avoid using unnecessary typedefs for TDataSet (#483)

The typedefs aliasing St_DataSet to TDataSet are not required. This
prevents us from running some nightly tests which load DB tables which
utilize this alias.

Fix error: unknown type name 'St_DataSet' in ROOT6 tests

```
LoadTable: .L /star-sw/StarDb/tpc/tsspars/tsspar.y2019.C
In file included from input_line_851:1:
/star-sw/StarDb/tpc/tsspars/tsspar.y2019.C:3:1: error: unknown type name 'St_DataSet'
St_DataSet *CreateTable() {
^
/star-sw/StarDb/tpc/tsspars/tsspar.y2019.C:57:10: error: use of undeclared identifier 'St_DataSet'
 return (St_DataSet *)tableSet;
         ^
/star-sw/StarDb/tpc/tsspars/tsspar.y2019.C:57:22: error: expected expression
 return (St_DataSet *)tableSet;
                     ^
root4star: .sl79_gcc485/OBJ/StRoot/St_db_Maker/St_db_Maker.cxx:932: virtual TDataSet* St_db_Maker::LoadTable(TDataSet*): Assertion `!ee' failed.
sh: line 1:   133 Aborted                 (core dumped) MALLOC_CHECK_=3 root4star -b -q -l 'bfc.C(50, "pp2022,StiCA,BEmcChkStat,ftt,-picowrite,-hitfilt,-evout", "/star/rcf/test/daq/2022/040/23040001/st_fwd_23040001_raw_0000003.daq")'
Error: Process completed with exit code 134.
```

StarDb/ctf/ctg/ctb.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/ctg/ctb Allocated rows: 1  Used rows: 1  Row size: 68 bytes
 //  Table: ctg_geo_st[0]--> ctg_geo_st[0]
@@ -28,5 +28,5 @@ memset(&row,0,tableSet->GetRowSize());
     row.tray_phi_zero	 =          0; // ;
 tableSet->AddAt(&row,0);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/ctf/ctg/ctb_slat.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // params/ctf/ctg/ctb_slat Allocated rows: 240  Used rows: 240  Row size: 32 bytes
 //  Table: ctg_slat_st[0]--> ctg_slat_st[239]
@@ -23,5 +23,5 @@ St_ctg_slat *tableSet = new St_ctg_slat("ctb_slat",240);
    }
  }
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/ctf/ctg/ctb_slat_eta.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/ctg/ctb_slat_eta Allocated rows: 4  Used rows: 4  Row size: 36 bytes
 //  Table: ctg_slat_eta_st[0]--> ctg_slat_eta_st[3]
@@ -53,5 +53,5 @@ memset(&row,0,tableSet->GetRowSize());
     row.z_min	 =     241.49; // ;
 tableSet->AddAt(&row,3);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/ctf/ctg/ctb_slat_phi.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/ctg/ctb_slat_phi Allocated rows: 60  Used rows: 60  Row size: 16 bytes
 //  Table: ctg_slat_phi_st[0]--> ctg_slat_phi_st[59]
@@ -369,5 +369,5 @@ memset(&row,0,tableSet->GetRowSize());
     row.phi_min	 =    351.092; // ;
 tableSet->AddAt(&row,59);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/ctf/ctg/tof.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/ctg/tof Allocated rows: 1  Used rows: 1  Row size: 68 bytes
 //  Table: ctg_geo_st[0]--> ctg_geo_st[0]
@@ -28,5 +28,5 @@ memset(&row,0,tableSet->GetRowSize());
     row.tray_phi_zero	 =          0; // ;
 tableSet->AddAt(&row,0);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/ctf/ctg/tof_slat.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // params/ctf/ctg/tof_slat Allocated rows: 5400  Used rows: 5400  Row size: 32 bytes
 //  Table: ctg_slat_st[0]--> ctg_slat_st[5399]
@@ -23,5 +23,5 @@ St_ctg_slat *tableSet = new St_ctg_slat("tof_slat",5400);
    }
  }
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/ctf/ctg/tof_slat_eta.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/ctg/tof_slat_eta Allocated rows: 18  Used rows: 18  Row size: 36 bytes
 //  Table: ctg_slat_eta_st[0]--> ctg_slat_eta_st[17]
@@ -207,5 +207,5 @@ memset(&row,0,tableSet->GetRowSize());
     row.z_min	 =     205.56; // ;
 tableSet->AddAt(&row,17);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/ctf/ctg/tof_slat_phi.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/ctg/tof_slat_phi Allocated rows: 300  Used rows: 300  Row size: 16 bytes
 //  Table: ctg_slat_phi_st[0]--> ctg_slat_phi_st[299]
@@ -1809,5 +1809,5 @@ memset(&row,0,tableSet->GetRowSize());
     row.phi_min	 =    355.732; // ;
 tableSet->AddAt(&row,299);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/ctf/cts/cts_ctb.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/cts/cts_ctb Allocated rows: 1  Used rows: 1  Row size: 1076 bytes
 //  Table: cts_mpara_st[0]--> cts_mpara_st[0]
@@ -280,5 +280,5 @@ memset(&row,0,tableSet->GetRowSize());
     row.zero_suppression	 =          1; // ;
 tableSet->AddAt(&row,0);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/ctf/cts/cts_tof.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/cts/cts_tof Allocated rows: 1  Used rows: 1  Row size: 1076 bytes
 //  Table: cts_mpara_st[0]--> cts_mpara_st[0]
@@ -280,5 +280,5 @@ memset(&row,0,tableSet->GetRowSize());
     row.zero_suppression	 =          1; // ;
 tableSet->AddAt(&row,0);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/ebye/sca/sca_const.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/sca/sca_const Allocated rows: 1  Used rows: 1  Row size: 112 bytes
 //  Table: sca_const_st[0]--> sca_const_st[0]
@@ -39,5 +39,5 @@ memset(&row,0,tableSet->GetRowSize());
     row.perfectdither	 =          0; // ;
 tableSet->AddAt(&row,0);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/ebye/sca/sca_filter_const.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/sca/sca_filter_const Allocated rows: 1  Used rows: 1  Row size: 28 bytes
 //  Table: sca_filter_const_st[0]--> sca_filter_const_st[0]
@@ -18,5 +18,5 @@ memset(&row,0,tableSet->GetRowSize());
     row.nGoodTraks	 =         50; // total no. of good tracks    ;
 tableSet->AddAt(&row,0);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/ebye/sca/sca_switch.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/sca/sca_switch Allocated rows: 1  Used rows: 1  Row size: 16 bytes
 //  Table: sca_switch_st[0]--> sca_switch_st[0]
@@ -15,5 +15,5 @@ memset(&row,0,tableSet->GetRowSize());
     row.nEvents	 =          0; // ;
 tableSet->AddAt(&row,0);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/emc/cal/ems_cal_control.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/cal/ems_cal_control Allocated rows: 1  Used rows: 1  Row size: 52 bytes
 //  Table: ems_cal_control_st[0]--> ems_cal_control_st[0]
@@ -25,5 +25,5 @@ memset(&row,0,tableSet->GetRowSize());
     row.occupancy	 =        0.5; // hit occupancy toy_simulator mode=1 ;
 tableSet->AddAt(&row,0);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/emc/cal/org_ped_bemc.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/cal/org_ped_bemc Allocated rows: 4800  Used rows: 4800  Row size: 4 bytes
 //  Table: emc_pedestal_st[0]--> emc_pedestal_st[4799]
@@ -12,5 +12,5 @@ St_DataSet *CreateTable() {
   row.ped	 =          0; // pedestal for ADC channel ;
   for (Int_t i=0;i<4800;i++) tableSet->AddAt(&row,i);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/emc/cal/org_ped_bemc_h.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/cal/org_ped_bemc_h Allocated rows: 1  Used rows: 1  Row size: 24 bytes
 //  Table: emc_calib_header_st[0]--> emc_calib_header_st[0]
@@ -19,5 +19,5 @@ memset(&row,0,tableSet->GetRowSize());
     row.nsub	 =          2; // see emc_def.h ;
 tableSet->AddAt(&row,0);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/emc/cal/org_ped_bprs.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/cal/org_ped_bprs Allocated rows: 4800  Used rows: 4800  Row size: 4 bytes
 //  Table: emc_pedestal_st[0]--> emc_pedestal_st[4799]
@@ -12,5 +12,5 @@ St_DataSet *CreateTable() {
   row.ped	 =          0; // pedestal for ADC channel ;
   for (Int_t i=0;i<4800;i++) tableSet->AddAt(&row,i);
   // ----------------- end of code ---------------
-  return (St_DataSet *)tableSet;
+  return (TDataSet *)tableSet;
 }

StarDb/emc/cal/org_ped_bprs_h.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/cal/org_ped_bprs_h Allocated rows: 1  Used rows: 1  Row size: 24 bytes
 //  Table: emc_calib_header_st[0]--> emc_calib_header_st[0]
@@ -19,5 +19,5 @@ memset(&row,0,tableSet->GetRowSize());
     row.nsub	 =          2; // see emc_def.h ;
 tableSet->AddAt(&row,0);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/emc/cal/org_ped_bsmde.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/cal/org_ped_bsmde Allocated rows: 18000  Used rows: 18000  Row size: 4 bytes
 //  Table: emc_pedestal_st[0]--> emc_pedestal_st[17999]
@@ -10,5 +10,5 @@ St_DataSet *CreateTable() {
   row.ped	 =          0; // pedestal for ADC channel ;
   for (Int_t i=0;i<18000;i++) tableSet->AddAt(&row,i);
   // ----------------- end of code ---------------
-  return (St_DataSet *)tableSet;
+  return (TDataSet *)tableSet;
 }

StarDb/emc/cal/org_ped_bsmde_h.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/cal/org_ped_bsmde_h Allocated rows: 1  Used rows: 1  Row size: 24 bytes
 //  Table: emc_calib_header_st[0]--> emc_calib_header_st[0]
@@ -19,5 +19,5 @@ memset(&row,0,tableSet->GetRowSize());
     row.nsub	 =          1; // see emc_def.h ;
 tableSet->AddAt(&row,0);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/emc/cal/org_ped_bsmdp.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/cal/org_ped_bsmdp Allocated rows: 18000  Used rows: 18000  Row size: 4 bytes
 //  Table: emc_pedestal_st[0]--> emc_pedestal_st[17999]
@@ -12,5 +12,5 @@ St_DataSet *CreateTable() {
   for (Int_t i=0;i<18000;i++) tableSet->AddAt(&row,i);
 //
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/emc/cal/org_ped_bsmdp_h.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/cal/org_ped_bsmdp_h Allocated rows: 1  Used rows: 1  Row size: 24 bytes
 //  Table: emc_calib_header_st[0]--> emc_calib_header_st[0]
@@ -19,5 +19,5 @@ memset(&row,0,tableSet->GetRowSize());
     row.nsub	 =         15; // see emc_def.h ;
 tableSet->AddAt(&row,0);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/emc/cal/org_ped_eemc.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/cal/org_ped_eemc Allocated rows: 1440  Used rows: 1440  Row size: 4 bytes
 //  Table: emc_pedestal_st[0]--> emc_pedestal_st[1439]
@@ -12,5 +12,5 @@ St_DataSet *CreateTable() {
   row.ped	 =          0; // pedestal for ADC channel ;
    for (Int_t i=0;i<1440;i++) tableSet->AddAt(&row,i); 
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/emc/cal/org_ped_eemc_h.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/cal/org_ped_eemc_h Allocated rows: 1  Used rows: 1  Row size: 24 bytes
 //  Table: emc_calib_header_st[0]--> emc_calib_header_st[0]
@@ -19,5 +19,5 @@ memset(&row,0,tableSet->GetRowSize());
     row.nsub	 =          5; // see emc_def.h ;
 tableSet->AddAt(&row,0);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/emc/cal/org_ped_eprs.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/cal/org_ped_eprs Allocated rows: 1440  Used rows: 1440  Row size: 4 bytes
 //  Table: emc_pedestal_st[0]--> emc_pedestal_st[1439]
@@ -12,5 +12,5 @@ St_DataSet *CreateTable() {
   row.ped	 =          0; // pedestal for ADC channel ;
   for (Int_t i=0;i<1440;i++) tableSet->AddAt(&row,i);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/emc/cal/org_ped_eprs_h.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/cal/org_ped_eprs_h Allocated rows: 1  Used rows: 1  Row size: 24 bytes
 //  Table: emc_calib_header_st[0]--> emc_calib_header_st[0]
@@ -19,5 +19,5 @@ memset(&row,0,tableSet->GetRowSize());
     row.nsub	 =          5; // see emc_def.h ;
 tableSet->AddAt(&row,0);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/emc/cal/org_slp_bemc.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/cal/org_slp_bemc Allocated rows: 4800  Used rows: 4800  Row size: 4 bytes
 //  Table: emc_adcslope_st[0]--> emc_adcslope_st[4799]
@@ -12,5 +12,5 @@ St_DataSet *CreateTable() {
   row.p0	 =          1; // adc slope for ADC channel ;
   for (Int_t i=0;i<4800;i++) tableSet->AddAt(&row,i);
   // ----------------- end of code ---------------
-  return (St_DataSet *)tableSet;
+  return (TDataSet *)tableSet;
 }

StarDb/emc/cal/org_slp_bemc_h.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/cal/org_slp_bemc_h Allocated rows: 1  Used rows: 1  Row size: 24 bytes
 //  Table: emc_calib_header_st[0]--> emc_calib_header_st[0]
@@ -19,5 +19,5 @@ memset(&row,0,tableSet->GetRowSize());
     row.nsub	 =          2; // see emc_def.h ;
 tableSet->AddAt(&row,0);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/emc/cal/org_slp_bprs.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/cal/org_slp_bprs Allocated rows: 4800  Used rows: 4800  Row size: 4 bytes
 //  Table: emc_adcslope_st[0]--> emc_adcslope_st[4799]
@@ -11,5 +11,5 @@ St_DataSet *CreateTable() {
   row.p0       =          1; // adc slope for ADC channel ;
   for (Int_t i=0;i<4800;i++) tableSet->AddAt(&row,i);
   // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }

StarDb/emc/cal/org_slp_bprs_h.C

@@ -1,4 +1,4 @@
-St_DataSet *CreateTable() { 
+TDataSet *CreateTable() { 
 // -----------------------------------------------------------------
 // Top/cal/org_slp_bprs_h Allocated rows: 1  Used rows: 1  Row size: 24 bytes
 //  Table: emc_calib_header_st[0]--> emc_calib_header_st[0]
@@ -19,5 +19,5 @@ memset(&row,0,tableSet->GetRowSize());
     row.nsub	 =          2; // see emc_def.h ;
 tableSet->AddAt(&row,0);
 // ----------------- end of code ---------------
- return (St_DataSet *)tableSet;
+ return (TDataSet *)tableSet;
 }