Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Thermal Expansion support? #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix Thermal Expansion support? #8

wants to merge 3 commits into from

Conversation

copygirl
Copy link
Contributor

@copygirl copygirl commented Feb 9, 2014

I was looking into why Thermal Expansion recipes weren't working with MineTweaker again after giving up the first time. Looking at IMC messages, it seems like they might only get sent before a mod reaches post-init state..? I'd love it if you could compile the mod for me to test, you don't have to accept the pull request right now.

By the way, dependencies = "before:ThermalExpansion" doesn't mean TE is required (that would be required-before), it'll just make sure it's loaded before TE if it is there.

Update: Description outdated, see comments below.

@stanhebben
Copy link
Owner

Minetweaker is designed to run after everything else, so that change might break a few things. But I will compile a version for you with that change later this afternoon so you can test that hypotheses.

@copygirl
Copy link
Contributor Author

copygirl commented Feb 9, 2014

I see. Perhaps we can implement this differently, like sending the IMC message directly to Thermal Expansion, which should work. Having something to test if this actually works would be really nice though.

@copygirl
Copy link
Contributor Author

Tested it and doesn't work. My guess is all the mods are switched over to post-init before any of the mods actually receive and post init events. I'll see about implementing what I said above.

@copygirl
Copy link
Contributor Author

Here is another attempt at it. I'll see about compiling it myself this time.

@copygirl
Copy link
Contributor Author

Compiling was successful, but the recipes are still not working. I've only really had time to check it and couldn't really get into debugging anything just yet, but I'll get to that soon.

@copygirl
Copy link
Contributor Author

copygirl commented Mar 1, 2014

Well, apparently there is no way to add Thermal Expansion support, at least not through IMC. Thermal Expansion seems to need its recipe information before the postInit event and that's where MineTweaker does its thing. Any idea how we could work around that? Would it be feasible to move the script evaluation to the init event, somehow making sure MT runs as the last mod?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants