Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include CmdStan CPPFLAGS when exposing functions #1003

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

andrjohns
Copy link
Collaborator

Submission Checklist

  • Run unit tests
  • Declare copyright holder and agree to license (see below)

Summary

From issue on the forums: some flags in make/local (e.g., TBB_INTERFACE_NEW, etc.) weren't being passed to Rcpp when exposing functions and model methods

Copyright and Licensing

Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses:

Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.89%. Comparing base (b271b7b) to head (8cfd4a5).
Report is 24 commits behind head on master.

Current head 8cfd4a5 differs from pull request most recent head 7c55d5d

Please upload reports for the commit 7c55d5d to get more accurate results.

Files Patch % Lines
R/utils.R 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1003      +/-   ##
==========================================
+ Coverage   84.20%   85.89%   +1.68%     
==========================================
  Files          13       13              
  Lines        4793     4800       +7     
==========================================
+ Hits         4036     4123      +87     
+ Misses        757      677      -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrjohns andrjohns merged commit 284a10c into master Jun 28, 2024
11 checks passed
@jgabry jgabry deleted the cmdstan-cppflags branch June 28, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants