Merge pull request #1057 from stan-dev/fix_loo_r_eff_overflow

fix translation of log liks before exponentiation
stan-dev · Jan 15, 2025 · ce58981 · ce58981
2 parents 79d3779 + 0436f37
commit ce58981
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/R/fit.R b/R/fit.R
@@ -1543,7 +1543,8 @@ loo <- function(variables = "log_lik", r_eff = TRUE, moment_match = FALSE, ...)
   if (is.logical(r_eff)) {
     if (isTRUE(r_eff)) {
       r_eff_cores <- list(...)[["cores"]] %||% getOption("mc.cores", 1)
-      r_eff <- loo::relative_eff(exp(LLarray + max(-LLarray)), cores = r_eff_cores)
+      r_eff <- loo::relative_eff(exp(sweep(LLarray, 3, apply(LLarray, 3, max), FUN = "-")),
+                                 cores = r_eff_cores)
     } else {
       r_eff <- NULL
     }