-
-
Notifications
You must be signed in to change notification settings - Fork 62
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #952 from stan-dev/rtools44-compat
Add handling for new rtools version
- Loading branch information
Showing
5 changed files
with
13 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,11 +37,8 @@ jobs: | |
|
||
- uses: actions/checkout@v4 | ||
|
||
- uses: r-lib/actions/[email protected] | ||
with: | ||
r-version: 'release' | ||
rtools-version: '42' | ||
- uses: r-lib/actions/[email protected] | ||
- uses: r-lib/actions/[email protected] | ||
- uses: r-lib/actions/[email protected] | ||
|
||
- name: Query dependencies | ||
run: | | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,11 +57,11 @@ jobs: | |
sudo apt-get install -y libcurl4-openssl-dev || true | ||
sudo apt-get install -y openmpi-bin openmpi-common libopenmpi-dev || true | ||
- uses: r-lib/actions/[email protected].4 | ||
- uses: r-lib/actions/[email protected].7 | ||
with: | ||
r-version: ${{ matrix.config.r }} | ||
rtools-version: ${{ matrix.config.rtools }} | ||
- uses: r-lib/actions/[email protected].4 | ||
- uses: r-lib/actions/[email protected].7 | ||
|
||
- name: Query dependencies | ||
run: | | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,8 +34,8 @@ jobs: | |
if: "!startsWith(github.ref, 'refs/tags/') && github.ref != 'refs/heads/master'" | ||
- uses: actions/checkout@v4 | ||
|
||
- uses: r-lib/actions/[email protected].4 | ||
- uses: r-lib/actions/[email protected].4 | ||
- uses: r-lib/actions/[email protected].7 | ||
- uses: r-lib/actions/[email protected].7 | ||
|
||
- name: Install Ubuntu dependencies | ||
run: | | ||
|
@@ -85,12 +85,9 @@ jobs: | |
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- uses: r-lib/actions/[email protected] | ||
with: | ||
r-version: 'release' | ||
rtools-version: '42' | ||
- uses: r-lib/actions/[email protected] | ||
|
||
- uses: r-lib/actions/[email protected].4 | ||
- uses: r-lib/actions/[email protected].7 | ||
|
||
- name: Query dependencies | ||
run: | | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,12 +40,12 @@ jobs: | |
sudo apt-get install -y libcurl4-openssl-dev || true | ||
sudo apt-get install -y openmpi-bin openmpi-common libopenmpi-dev || true | ||
- uses: r-lib/actions/[email protected].4 | ||
- uses: r-lib/actions/[email protected].7 | ||
with: | ||
r-version: ${{ matrix.config.r }} | ||
rtools-version: ${{ matrix.config.rtools }} | ||
|
||
- uses: r-lib/actions/[email protected].4 | ||
- uses: r-lib/actions/[email protected].7 | ||
|
||
- name: Query dependencies | ||
run: | | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8af58b8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask why rtools 4.3 is required when R 4.4 is installed? rtools 4.4 is recommended for R 4.4 and higher, and now cmdstanr doesn't work anymore on R 4.4 because I don't have rtools 4.3 anymore.
Is there a compatibility issue, or would it be possible to make cmdstan(r) work with R 4.4 and rtools 4.4? That'd be great!
8af58b8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a typo, is being fixed now