More fixes

stan-dev · Jan 21, 2024 · 65cc780 · 65cc780
1 parent 006a7f2
commit 65cc780
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 12 deletions.
diff --git a/R/model.R b/R/model.R
@@ -716,7 +716,8 @@ compile <- function(quiet = TRUE,
       )
     }
 
-    writeLines(private$model_methods_env_$hpp_code_, private$hpp_file_)
+    writeLines(private$model_methods_env_$hpp_code_,
+               con = wsl_safe_path(private$hpp_file_, revert = TRUE))
   } # End - if(!dry_run)
 
   private$exe_file_ <- exe

diff --git a/tests/testthat/test-install.R b/tests/testthat/test-install.R
@@ -16,7 +16,7 @@ test_that("install_cmdstan() successfully installs cmdstan", {
       install_cmdstan(dir = dir, cores = 2, quiet = FALSE, overwrite = TRUE,
                       release_url = cmdstan_test_tarball_url,
                       wsl = os_is_wsl()),
-      "Compiling, linking C++ code",
+      "Compiling C++ code",
       fixed = TRUE
     ),
     "CmdStan path set",

diff --git a/tests/testthat/test-model-compile.R b/tests/testthat/test-model-compile.R
@@ -174,15 +174,6 @@ test_that("compile errors are shown", {
   )
 })
 
-test_that("compile suggests using format to fix old syntax", {
-  stan_file <- testing_stan_file("old_array_syntax")
-  expect_error(
-    cmdstan_model(stan_file),
-    "To fix deprecated or removed syntax please see ?cmdstanr::format for an example.",
-    fixed = TRUE
-  )
-})
-
 test_that("dir arg works for cmdstan_model and $compile()", {
   tmp_dir <- tempdir()
   tmp_dir_2 <- tempdir()
@@ -858,4 +849,3 @@ test_that("STANCFLAGS included from make/local", {
   expect_output(print(out), out_w_flags)
   cmdstan_make_local(cpp_options = make_local_old, append = FALSE)
 })
-