Update tests, fix windows error

stan-dev · Jun 8, 2024 · 6019efe · 6019efe
1 parent 8ea0d4a
commit 6019efe
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 25 deletions.
diff --git a/R/args.R b/R/args.R
@@ -1317,13 +1317,13 @@ process_init_approx <- function(init, num_procs, model_variables = NULL,
   # Calculate unique draws based on 'lw' using base R functions
   unique_draws = length(unique(draws_df$lw))
   if (num_procs > unique_draws) {
-    if (inherits(init, " CmdStanPathfinder ")) {
+    if (inherits(init, "CmdStanPathfinder")) {
       algo_name = " Pathfinder "
       extra_msg = " Try running Pathfinder with psis_resample=FALSE."
     } else if (inherits(init, "CmdStanVB")) {
       algo_name = " CmdStanVB "
       extra_msg = ""
-    } else if (inherits(init, " CmdStanLaplace ")) {
+    } else if (inherits(init, "CmdStanLaplace")) {
       algo_name = " CmdStanLaplace "
       extra_msg = ""
     } else {

diff --git a/tests/testthat/resources/stan/issue_975.stan b/tests/testthat/resources/stan/issue_975.stan
diff --git a/tests/testthat/test-init-issue975.R b/tests/testthat/test-init-issue975.R
diff --git a/tests/testthat/test-model-init.R b/tests/testthat/test-model-init.R
@@ -310,3 +310,28 @@ test_that("Initial values for single-element containers treated correctly", {
     )
   )
 })
+
+test_that("Pathfinder inits do not drop dimensions", {
+  modcode <- "
+  data {
+    int N;
+    vector[N] y;
+  }
+
+  parameters {
+    matrix[N, 1] mu;
+    matrix[1, N] mu_2;
+    vector<lower=0>[N] sigma;
+  }
+
+  model {
+    target += normal_lupdf(y | mu[:, 1], sigma);
+    target += normal_lupdf(y | mu_2[1], sigma);
+  }
+  "
+  mod <- cmdstan_model(write_stan_file(modcode), force_recompile = TRUE)
+  data <- list(N = 100, y = rnorm(100))
+  pf <- mod$pathfinder(data = data, psis_resample = FALSE)
+  expect_no_error(fit <- mod$sample(data = data, init = pf, chains = 1,
+                                    iter_warmup = 100, iter_sampling = 100))
+})