This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Sync with reactjs.org @ c7d85894 #203
Open
react-translations-bot
wants to merge
324
commits into
main
Choose a base branch
from
sync-c7d85894
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replaced old ReactDOM API with new React v18 API Replaced old ReactDOM API with new React v18 API ReactDOM.render( // Try changing to isLoggedIn={true}: <Greeting isLoggedIn={false} />, document.getElementById('root') ); The above implementation has been replaced by the following implementation according to React v18. ReactDOM .createRoot(document.getElementById('root')) .render(<LoginControl />); * Changed ReactDOM.createRoot syntax into two lines ``` ReactDOM .createRoot(document.getElementById('root')) .render(<LoginControl />); ``` has been changed to ``` const root = ReactDOM.createRoot(document.getElementById('root')); root.render(<LoginControl />); ``` * Added a comment on <Greeting/> comp.
* Update more examples for 18 * blargh
…g (#4618) * Explicitly list what methods are included in unmounting and remounting * Move up
* Changing the markdown - Initial commit * Adding the missing instruction to copy the JS and CSS from starter code * reverting the extra text added
Signed-off-by: Jie Peng <[email protected]>
* [Beta] Replace SVGs with PNGs * Fix up sizes
* added sandpack linter and installed latest sandpacl * integrate eslint into Sandpack * Format the linting errors, disable preview on lint error, have only two react hooks * fixes build * split eslint-integration * fix tooltip text color, error rename to 'Lint Error', show single lint error * NIT * Just enable it * Delete eslint.md Co-authored-by: Strek <[email protected]> Co-authored-by: dan <[email protected]>
* add new bundle for testing * add timer * update url * update bundler version * Remove temporary code * Fix lint * why? * testing bundler url * uncaught exception handling * catch global errors on new bundler * Try latest bundler Co-authored-by: Dan Abramov <[email protected]>
* [Beta] Lazy-load linter code * Split utils into separate files
* [Beta] Wrap the period after the link inside the link * [Beta] Update community Doc * [Beta] Resolve confilicts
* [Beta] Update links for React Router 6.4+ * [Beta] Update the link for Strict Mode
* [Beta] Avoid grey screen on Safari iOS swipe * Gate to Safari
* Revert "Revert "[beta] upgrade sandpack and refactor sandpack.css (#4843)" (#4959)" This reverts commit da6a06e. * Fix tabbing * Fixes * More bump * Bump bundler * Fix overflows
* [Beta] Remove `useEvent` link * [Beta] Add `useEvent` stub page * [Beta] Update `useEvent` description * Update useEvent.md * Alphabetical Co-authored-by: dan <[email protected]>
* add loading indicator to sidebar links * replace backslashes with slashes * bumping DISK_CACHE_BREAKER * using replace instead or replaceAll
* [Beta] Fix navigation sticky failure * [Beta] Remove overflow-x from body * [Beta] Update the max-with * Update index.css Co-authored-by: dan <[email protected]>
Deployment failed with the following error:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from reactjs.org at c7d8589
The following files have conflicts and may need new translations:
Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.