[fix] analysis -> point in time

[hrodmn]

Tag all layers where forecast_valid == 'analysis' as point_in_time to facilitate better datacube structure.

[abarciauskas-bgse]

@hrodmn thanks for making this change. Just to make sure I understand, was the original intent of point_in_time to distinguish between data produced for forecast hour 0 vs all other files (forecast hour 1+), but the underlying metric is the same? In this case, do we need the point_in_time suffix at all? I see that the other forecast "types" (cumulative, summary) are different enough that point in time makes sense).

I noticed for wind speed, there are "instantaneous" variables for forecast hour 0 and periodic max for all other hours. I would assume these are different metrics so I'm wondering how I should annotate that in the UI 🤔

[hrodmn]

Just to make sure I understand, was the original intent of point_in_time to distinguish between data produced for forecast hour 0 vs all other files (forecast hour 1+), but the underlying metric is the same? In this case, do we need the point_in_time suffix at all? I see that the other forecast "types" (cumulative, summary) are different enough that point in time makes sense).

Yeah, many of the variables have forecast_valid values that reflect some statistic about a specific range (periodic), or from hour zero to time x (cumulative). The values like 3 hour fcst represent conditions at a specific point in time (I think).

I noticed for wind speed, there are "instantaneous" variables for forecast hour 0 and periodic max. I would assume these are different metrics so I'm wondering how I should annotate that in the UI 🤔

I am not really sure what the "instantaneous" observations mean. I labeled them this way when the forecast_valid string is something like 0-0 day max (see https://www.nco.ncep.noaa.gov/pmb/products/hrrr/hrrr.t00z.wrfsfcf00.grib2.shtml which that shows those rows in the inventory table). Maybe that is a bad label. Since those values only appear in FH 0 maybe it would make sense to skip them for the UI.