NOAA Sea Ice CDR updates #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
requested changes
Aug 2, 2024
There was a problem hiding this comment.
Thanks for the contribution! There's a couple of inline comments, and it looks like the tests aren't passing, so that will need to be fixed.
One additional ask, can you add (or update) a script to generate the new examples? We'll want that to be reproducible. TIA
Co-authored-by: Pete Gadomski <[email protected]>
Co-authored-by: Pete Gadomski <[email protected]>
gadomski
approved these changes
Aug 19, 2024
|
🥳 merged! Thanks @rmarow! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before you submit a pull request, please fill in the following:
Related Issue(s):
Please add links (if any) to related github issues.
Description:
I made a few alterations to the collection - fixed a broken link and added keywords.
Added platform and instrument to item creation method.
Added a bunch of items.
PR checklist:
scripts/format).scripts/lint).scripts/test).