Skip to content

Commit

Permalink
Merge pull request #5380 from stacks-network/fix/miner-recovers-when-…
Browse files Browse the repository at this point in the history 
…broadcast-block-delay-across-tenures-occurs

Fix miner_recovers_when_broadcast_block_delay_across_tenures_occurs: Do not expect an exact number of signatures
  • Loading branch information
@jferrant
jferrant authored Oct 24, 2024
2 parents 12296c7 + 6fa2b6d commit f759c95
Showing 1 changed file with 63 additions and 93 deletions.
156 changes: 63 additions & 93 deletions testnet/stacks-node/src/tests/signer/v0.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4804,18 +4804,10 @@ fn miner_recovers_when_broadcast_block_delay_across_tenures_occurs() {
vec![(sender_addr.clone(), (send_amt + send_fee) * nmb_txs)],
);
let http_origin = format!("http://{}", &signer_test.running_nodes.conf.node.rpc_bind);
let short_timeout = Duration::from_secs(30);
signer_test.boot_to_epoch_3();

info!("------------------------- Starting Tenure A -------------------------");
info!("------------------------- Test Mine Nakamoto Block N -------------------------");
let mined_blocks = signer_test.running_nodes.nakamoto_blocks_mined.clone();
let blocks_before = mined_blocks.load(Ordering::SeqCst);
let info_before = signer_test
.stacks_client
.get_peer_info()
.expect("Failed to get peer info");
let start_time = Instant::now();

// wait until we get a sortition.
// we might miss a block-commit at the start of epoch 3
Expand All @@ -4828,6 +4820,12 @@ fn miner_recovers_when_broadcast_block_delay_across_tenures_occurs() {
})
.expect("Timed out waiting for sortition");

let mined_blocks = signer_test.running_nodes.nakamoto_blocks_mined.clone();
let blocks_before = mined_blocks.load(Ordering::SeqCst);
let info_before = signer_test
.stacks_client
.get_peer_info()
.expect("Failed to get peer info");
// submit a tx so that the miner will mine a stacks block
let mut sender_nonce = 0;
let transfer_tx = make_stacks_transfer(
Expand All @@ -4842,13 +4840,10 @@ fn miner_recovers_when_broadcast_block_delay_across_tenures_occurs() {
info!("Submitted tx {tx} in to mine block N");

// a tenure has begun, so wait until we mine a block
while mined_blocks.load(Ordering::SeqCst) <= blocks_before {
assert!(
start_time.elapsed() < short_timeout,
"FAIL: Test timed out while waiting for block production",
);
thread::sleep(Duration::from_secs(1));
}
wait_for(30, || {
Ok(mined_blocks.load(Ordering::SeqCst) > blocks_before)
})
.expect("Timed out waiting for block to be mined and processed");

sender_nonce += 1;
let info_after = signer_test
Expand Down Expand Up @@ -4892,61 +4887,51 @@ fn miner_recovers_when_broadcast_block_delay_across_tenures_occurs() {
let tx = submit_tx(&http_origin, &transfer_tx);

info!("Submitted tx {tx} in to attempt to mine block N+1");
let start_time = Instant::now();
let mut block = None;
loop {
if block.is_none() {
block = test_observer::get_stackerdb_chunks()
.into_iter()
.flat_map(|chunk| chunk.modified_slots)
.find_map(|chunk| {
let message = SignerMessage::consensus_deserialize(&mut chunk.data.as_slice())
.expect("Failed to deserialize SignerMessage");
match message {
SignerMessage::BlockProposal(proposal) => {
if proposal.block.header.consensus_hash
== info_before.stacks_tip_consensus_hash
{
Some(proposal.block)
} else {
None
}
wait_for(30, || {
block = test_observer::get_stackerdb_chunks()
.into_iter()
.flat_map(|chunk| chunk.modified_slots)
.find_map(|chunk| {
let message = SignerMessage::consensus_deserialize(&mut chunk.data.as_slice())
.expect("Failed to deserialize SignerMessage");
match message {
SignerMessage::BlockProposal(proposal) => {
if proposal.block.header.consensus_hash
== info_before.stacks_tip_consensus_hash
{
Some(proposal.block)
} else {
None
}
_ => None,
}
});
}
if let Some(block) = &block {
let signatures = test_observer::get_stackerdb_chunks()
.into_iter()
.flat_map(|chunk| chunk.modified_slots)
.filter_map(|chunk| {
let message = SignerMessage::consensus_deserialize(&mut chunk.data.as_slice())
.expect("Failed to deserialize SignerMessage");
match message {
SignerMessage::BlockResponse(BlockResponse::Accepted(accepted)) => {
if block.header.signer_signature_hash()
== accepted.signer_signature_hash
{
Some(accepted.signature)
} else {
None
}
_ => None,
}
});
let Some(block) = &block else {
return Ok(false);
};
let signatures = test_observer::get_stackerdb_chunks()
.into_iter()
.flat_map(|chunk| chunk.modified_slots)
.filter_map(|chunk| {
let message = SignerMessage::consensus_deserialize(&mut chunk.data.as_slice())
.expect("Failed to deserialize SignerMessage");
match message {
SignerMessage::BlockResponse(BlockResponse::Accepted(accepted)) => {
if block.header.signer_signature_hash() == accepted.signer_signature_hash {
Some(accepted.signature)
} else {
None
}
_ => None,
}
})
.collect::<Vec<_>>();
if signatures.len() == num_signers {
break;
}
}
assert!(
start_time.elapsed() < short_timeout,
"FAIL: Test timed out while waiting for signers signatures for first block proposal",
);
sleep_ms(1000);
}
_ => None,
}
})
.collect::<Vec<_>>();
Ok(signatures.len() == num_signers)
})
.expect("Test timed out while waiting for signers signatures for first block proposal");
let block = block.unwrap();

let blocks_after = mined_blocks.load(Ordering::SeqCst);
Expand Down Expand Up @@ -4979,9 +4964,8 @@ fn miner_recovers_when_broadcast_block_delay_across_tenures_occurs() {
"------------------------- Attempt to Mine Nakamoto Block N+1' -------------------------"
);
// Wait for the miner to propose a new invalid block N+1'
let start_time = Instant::now();
let mut rejected_block = None;
while rejected_block.is_none() {
wait_for(30, || {
rejected_block = test_observer::get_stackerdb_chunks()
.into_iter()
.flat_map(|chunk| chunk.modified_slots)
Expand All @@ -5002,11 +4986,9 @@ fn miner_recovers_when_broadcast_block_delay_across_tenures_occurs() {
_ => None,
}
});
assert!(
start_time.elapsed() < short_timeout,
"FAIL: Test timed out while waiting for N+1' block proposal",
);
}
Ok(rejected_block.is_some())
})
.expect("Timed out waiting for block proposal of N+1' block proposal");

info!("Allowing miner to accept block responses again. ");
TEST_IGNORE_SIGNERS.lock().unwrap().replace(false);
Expand All @@ -5015,7 +4997,7 @@ fn miner_recovers_when_broadcast_block_delay_across_tenures_occurs() {

// Assert the N+1' block was rejected
let rejected_block = rejected_block.unwrap();
loop {
wait_for(30, || {
let stackerdb_events = test_observer::get_stackerdb_chunks();
let block_rejections = stackerdb_events
.into_iter()
Expand All @@ -5037,14 +5019,9 @@ fn miner_recovers_when_broadcast_block_delay_across_tenures_occurs() {
}
})
.collect::<Vec<_>>();
if block_rejections.len() == num_signers {
break;
}
assert!(
start_time.elapsed() < short_timeout,
"FAIL: Test timed out while waiting for block proposal rejections",
);
}
Ok(block_rejections.len() == num_signers)
})
.expect("FAIL: Timed out waiting for block proposal rejections");

// Induce block N+2 to get mined
let transfer_tx = make_stacks_transfer(
Expand All @@ -5060,24 +5037,17 @@ fn miner_recovers_when_broadcast_block_delay_across_tenures_occurs() {
info!("Submitted tx {tx} in to attempt to mine block N+2");

info!("------------------------- Asserting a both N+1 and N+2 are accepted -------------------------");
loop {
wait_for(30, || {
// N.B. have to use /v2/info because mined_blocks only increments if the miner's signing
// coordinator returns successfully (meaning, mined_blocks won't increment for block N+1)
let info = signer_test
.stacks_client
.get_peer_info()
.expect("Failed to get peer info");

if info_before.stacks_tip_height + 2 <= info.stacks_tip_height {
break;
}

assert!(
start_time.elapsed() < short_timeout,
"FAIL: Test timed out while waiting for block production",
);
thread::sleep(Duration::from_secs(1));
}
Ok(info_before.stacks_tip_height + 2 <= info.stacks_tip_height)
})
.expect("Timed out waiting for blocks to be mined");

let info_after = signer_test
.stacks_client
Expand All @@ -5096,7 +5066,7 @@ fn miner_recovers_when_broadcast_block_delay_across_tenures_occurs() {
.expect("Not a Nakamoto block")
.signer_signature
.len();
assert_eq!(nmb_signatures, num_signers);
assert!(nmb_signatures >= num_signers * 7 / 10);

// Ensure that the block was accepted globally so the stacks tip has advanced to N+2
let nakamoto_blocks = test_observer::get_mined_nakamoto_blocks();
Expand Down

0 comments on commit f759c95

Please sign in to comment.