Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp wait package #131

Merged
merged 29 commits into from
Oct 27, 2023
Merged

Revamp wait package #131

merged 29 commits into from
Oct 27, 2023

Conversation

hcsa73
Copy link
Contributor

@hcsa73 hcsa73 commented Oct 26, 2023

  • Add generic to signature of wait function
  • Rename types and fields, add comments
  • Uniformize SetXXX signatures
  • Rewrite tests

examples/waiter/waiter.go Outdated Show resolved Hide resolved
core/wait/wait.go Outdated Show resolved Hide resolved
core/wait/wait.go Outdated Show resolved Hide resolved
core/wait/wait.go Outdated Show resolved Hide resolved
core/wait/wait.go Show resolved Hide resolved
core/wait/wait_test.go Outdated Show resolved Hide resolved
core/wait/wait_test.go Outdated Show resolved Hide resolved
core/wait/wait_test.go Show resolved Hide resolved
@hcsa73
Copy link
Contributor Author

hcsa73 commented Oct 26, 2023

Changed the rule for handlers for which the response part doesn't apply, uniformed implementation of Handlers and adapted tests

@hcsa73 hcsa73 merged commit c8ddfca into main Oct 27, 2023
6 checks passed
@hcsa73 hcsa73 deleted the hs/wait-improvements branch October 27, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants