-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Caracal's Magnum #1432
Use Caracal's Magnum #1432
Conversation
Perhaps should be merged without waiting for CI - Magnum's not tested. |
7073a06
to
66d7a73
Compare
25cc073
to
abe85b8
Compare
FWIW unpinning the driver version here feels wrong to me. Since we're not 100% in control of upstream driver releases, we could in theory be broken if other upstream Magnum core reviewers start becoming more active in the driver lifecycle and publishing releases themselves. Maybe we could pin to minor version so that we still get automatic patch releases when rebuilding containers? |
Pull request was converted to draft
54c3f4f
to
4843b9b
Compare
223a446
to
535ae17
Compare
The goal of this PR was to remove Antelope's pin on Magnum itself and it scope crept a little bit. Whether to unpin the driver should be a separate discussion, so I'm just bumping its version here. |
magnum-cluster-api
driver.To be merged after #1430.