Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Caracal's Magnum #1432

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Use Caracal's Magnum #1432

merged 1 commit into from
Jan 24, 2025

Conversation

cityofships
Copy link
Member

@cityofships cityofships commented Dec 20, 2024

  • Switch to Caracal release;
  • Remove magnum-cluster-api driver.

To be merged after #1430.

@cityofships cityofships requested a review from a team as a code owner December 20, 2024 13:55
@cityofships cityofships added Caracal Targets the Caracal OpenStack release magnum All things OpenStack Magnum related labels Dec 20, 2024
@cityofships
Copy link
Member Author

Perhaps should be merged without waiting for CI - Magnum's not tested.

mnasiadka
mnasiadka previously approved these changes Dec 23, 2024
@cityofships cityofships changed the title Use Caracal Magnum Use Caracal's Magnum Jan 2, 2025
@cityofships cityofships marked this pull request as draft January 2, 2025 09:26
@cityofships cityofships marked this pull request as ready for review January 2, 2025 14:32
@cityofships cityofships requested a review from mnasiadka January 2, 2025 14:33
@cityofships cityofships enabled auto-merge January 2, 2025 21:18
etc/kayobe/kolla.yml Outdated Show resolved Hide resolved
etc/kayobe/kolla.yml Outdated Show resolved Hide resolved
@sd109
Copy link
Member

sd109 commented Jan 7, 2025

FWIW unpinning the driver version here feels wrong to me. Since we're not 100% in control of upstream driver releases, we could in theory be broken if other upstream Magnum core reviewers start becoming more active in the driver lifecycle and publishing releases themselves. Maybe we could pin to minor version so that we still get automatic patch releases when rebuilding containers?

@cityofships cityofships marked this pull request as draft January 24, 2025 10:32
auto-merge was automatically disabled January 24, 2025 10:32

Pull request was converted to draft

@cityofships cityofships reopened this Jan 24, 2025
@cityofships cityofships marked this pull request as ready for review January 24, 2025 10:44
@cityofships
Copy link
Member Author

FWIW unpinning the driver version here feels wrong to me. Since we're not 100% in control of upstream driver releases, we could in theory be broken if other upstream Magnum core reviewers start becoming more active in the driver lifecycle and publishing releases themselves. Maybe we could pin to minor version so that we still get automatic patch releases when rebuilding containers?

The goal of this PR was to remove Antelope's pin on Magnum itself and it scope crept a little bit. Whether to unpin the driver should be a separate discussion, so I'm just bumping its version here.

@mnasiadka mnasiadka merged commit c4eead6 into stackhpc/2024.1 Jan 24, 2025
14 checks passed
@mnasiadka mnasiadka deleted the unpin_magnum branch January 24, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Caracal Targets the Caracal OpenStack release magnum All things OpenStack Magnum related size: s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants