Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Appcred authtype #49

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Appcred authtype #49

merged 3 commits into from
Mar 8, 2024

Conversation

scrungus
Copy link
Contributor

@scrungus scrungus commented Mar 6, 2024

we add the auth_type to the application credential secret for capi-janitor-system, as if it is not provided then upon cluster deletion we see:

Traceback (most recent call last):
  File "/venv/lib/python3.10/site-packages/capi_janitor/openstack/operator.py", line 266, in wrapper
    result = await handler(**kwargs)
  File "/venv/lib/python3.10/site-packages/capi_janitor/openstack/operator.py", line 381, in on_openstackcluster_event
    await purge_openstack_resources(
  File "/venv/lib/python3.10/site-packages/capi_janitor/openstack/operator.py", line 152, in purge_openstack_resources
    async with openstack.Cloud.from_clouds(clouds, cacert = cacert) as cloud:
  File "/venv/lib/python3.10/site-packages/capi_janitor/openstack/openstack.py", line 219, in from_clouds
    if config["auth_type"] != "v3applicationcredential":
KeyError: 'auth_type'

magnum_capi_helm/driver_utils.py Outdated Show resolved Hide resolved
magnum_capi_helm/driver.py Outdated Show resolved Hide resolved
magnum_capi_helm/tests/common/test_app_creds.py Outdated Show resolved Hide resolved
@scrungus scrungus requested a review from JohnGarbutt March 7, 2024 10:43
Copy link
Member

@mkjpryor mkjpryor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scrungus scrungus merged commit 1c7ec31 into main Mar 8, 2024
1 check passed
@scrungus scrungus deleted the appcred_authtype branch March 8, 2024 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants