Ignition driver

[stefan-chivu]

No description provided.

[dalees]

Hi Stefan, I've uploaded an alternative PR that just passes through the os_distro image parameter, which is essentially the same without the duplicated function here. Apologies for not uploading mine sooner; I was waiting for the final state of the Helm chart to be defined - I should have posted it anyway when it was using ignitionBasedOS and updated it.

I'm not opposed to splitting the driver into two classes, but IMHO the duplication in the _update_helm_release function is a bit much to merge as is (as also noted in your comment) - going to be a lot of features we add here! (I've got some pending PRs, uploading soon to try and avoid duplicated effort!)

[stefan-chivu]

Hi Stefan, I've uploaded an alternative PR that just passes through the os_distro image parameter, which is essentially the same without the duplicated function here. Apologies for not uploading mine sooner; I was waiting for the final state of the Helm chart to be defined - I should have posted it anyway when it was using ignitionBasedOS and updated it.

I'm not opposed to splitting the driver into two classes, but IMHO the duplication in the _update_helm_release function is a bit much to merge as is (as also noted in your comment) - going to be a lot of features we add here! (I've got some pending PRs, uploading soon to try and avoid duplicated effort!)

That's fair, since the only bit that requires a change for flatcar is the value passed for osDistro, it doesn't really pay off to have two classes with duplicate code. Another way would maybe imply having a base class for the driver, but I don't think that's gonna help much and it's not really worth the hassle.