This repository has been archived by the owner on Dec 5, 2024. It is now read-only.
Apply boot disk values from Magnum config #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows other conditionals to merge into the values for nodeGroupDefaults.
If Magnum configuration is set to define cinder volume size and types, use it to set the boot disk volumes. It's likely we'd want to separate the fields for control plane and workers, but this is a good start.
|
cc @JohnGarbutt |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One commit to change
extra_network_nameto merge instead of overwrite thenodeGroupDefaultsfield.Then, pass boot disk config through to CAPI helm charts, if it's set in Magnum config. A first pass, as there are several other relevant values in Magnum config for other volumes, and we may want to split by node type (worker, control plane).
Tests added, note that
test_create_cluster_boot_volume_extra_networkfails if the values do not merge intonodeGroupDefaults.