Skip to content
This repository has been archived by the owner on Mar 18, 2021. It is now read-only.

Fixing the way aqueduct TestRequest serializes list query parameters #901

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixing the way aqueduct TestRequest serializes list query parameters #901

wants to merge 2 commits into from

Conversation

Reductions
Copy link
Contributor

@Reductions Reductions commented Oct 1, 2020

Up until now list query parameters were serialized in such a way:

url?query=[1, 2]

This is not the way aqueduct expects list parameters to be sent with that pull request the way lists are serialized is:

url?query=1&query=2

Up until now list query parameters were serialized in such a way:
`url?query=[1, 2]`. This is not the way aqueduct expects list parameters to
be sent with that pull request the way lists are serialized is:
`url?query=1&query=2`
@ali-thowfeek
Copy link

@Reductions I was trying to write a test like

harness.publicAgent.get("/search", query: {"query": "1", "query": "2"});

But soon realized that it's impossible do that in dart with the map containing duplicate keys.
would this PR fix it? where i would be able to write

harness.publicAgent.get("/search", query: {"query": ["1", "2"]});

@Reductions
Copy link
Contributor Author

Yes it would. But it would not be merged as the framework is no longer supported. Run away while you have an option.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants