-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Mobile screen rotation fix #1194
base: master
Are you sure you want to change the base?
Conversation
…o the contributing docs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1194 +/- ##
==========================================
+ Coverage 92.93% 93.60% +0.67%
==========================================
Files 42 42
Lines 4569 4662 +93
Branches 648 660 +12
==========================================
+ Hits 4246 4364 +118
+ Misses 321 293 -28
- Partials 2 5 +3 ☔ View full report in Codecov by Sentry. |
The thought process behind the end designThe whole thing broke because I didnt check the mobile landscape mode 🙄, when I developed the more detailed session progress title text and didnt assume that someone moved everything around so dramatically. To fix this, I moved the progress text to the card context area, shrunk down the response buttons for small screens and only moved the upper control buttons to the left side in the landscape mode, such that more space is opened up for viewing the cards. I did my best to respect the wish to have more viewing space and at the same time to have a good and consistant design. PS.: The new contributing text is there so that no one repeats my mistakes 😅 |
… the chosen deck, if it is only one deck
…just like the bold text
This pr fixes the current visual bug, when the plugin is used on a mobile device in landscape mode (See pictures).
Further more this pr also adds a "how to develop & test ui changes" to the contribution page, so that these issues wont arise again in a future ui change.
PC design
For reference: Old design used on a pc
New design used on a pc
Mobile design
For reference: Old design on a mobile device in landscape mode with the visual bug
New design on a mobile device in landscape mode
Old design on a small mobile device in landscape mode with visual bug
New design on a small mobile device in landscape mode
New contributing text