Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mobile screen rotation fix #1194

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

KyleKlus
Copy link
Contributor

This pr fixes the current visual bug, when the plugin is used on a mobile device in landscape mode (See pictures).
Further more this pr also adds a "how to develop & test ui changes" to the contribution page, so that these issues wont arise again in a future ui change.

PC design


For reference: Old design used on a pc


New design used on a pc

Mobile design


For reference: Old design on a mobile device in landscape mode with the visual bug


New design on a mobile device in landscape mode


Old design on a small mobile device in landscape mode with visual bug


New design on a small mobile device in landscape mode

New contributing text

@KyleKlus KyleKlus marked this pull request as draft December 28, 2024 14:34
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.60%. Comparing base (f2379d1) to head (bded77c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1194      +/-   ##
==========================================
+ Coverage   92.93%   93.60%   +0.67%     
==========================================
  Files          42       42              
  Lines        4569     4662      +93     
  Branches      648      660      +12     
==========================================
+ Hits         4246     4364     +118     
+ Misses        321      293      -28     
- Partials        2        5       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KyleKlus KyleKlus marked this pull request as ready for review December 28, 2024 14:52
@KyleKlus
Copy link
Contributor Author

KyleKlus commented Dec 28, 2024

The thought process behind the end design

The whole thing broke because I didnt check the mobile landscape mode 🙄, when I developed the more detailed session progress title text and didnt assume that someone moved everything around so dramatically.
Someone wanted to make room in the mobile landscape mode and has thus moved all the buttons to the side, to open up some space in the middle (see #990 & #998).

To fix this, I moved the progress text to the card context area, shrunk down the response buttons for small screens and only moved the upper control buttons to the left side in the landscape mode, such that more space is opened up for viewing the cards. I did my best to respect the wish to have more viewing space and at the same time to have a good and consistant design.

PS.: The new contributing text is there so that no one repeats my mistakes 😅

@st3v3nmw st3v3nmw self-requested a review December 31, 2024 08:04
@KyleKlus
Copy link
Contributor Author

KyleKlus commented Jan 14, 2025

The last commit changes the looks of the deck progress info a tiny bit(see pictures below).

Changes:

  • Deck progress info now with bold font weight(highlights the usefullness of the information better):


  • Chosen deck progress info now without sub deck counter if there are no subdecks (removes redundant information for a better focus):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant