Fix amount check at deposit validate lost after merges #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pavelkrolevets
commented
Oct 16, 2024
pavelkrolevets
commented
- fix amount check pectra ready lost during merges https://github.com/ssvlabs/ssv-dkg/pull/127/files#diff-3b86fb7881073f8442330d0299604fee3701b99ffd02af55d47546f24cc5bf91L124-L125
- add test with 2048 ETH
MatusKysel
approved these changes
Oct 16, 2024
|
@MatusKysel this test https://github.com/ssvlabs/ssv-dkg/blob/fix-amount-deposit-validate/integration_test/reshare_threshold_old_ops_test.go#L26 is failing at CI but I cant reproduce at my machine. Can you please check? |
working fine for me, let me run all tests maybe it will fail and we have some issue on clean up or something |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.