Better logs #139
Merged
Better logs #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
MatusKysel
approved these changes
Oct 30, 2024
pkgs/initiator/initiator.go
Outdated
| @@ -896,6 +901,9 @@ func checkThreshold(responses map[uint64][]byte, errs map[uint64]error, oldOpera | |||
| var finalErr error | |||
| for _, op := range newOperators { | |||
| if err, ok := errs[op.ID]; ok { | |||
| if strings.Contains(err.Error(), "invalid ssz encoding") { | |||
| err = fmt.Errorf("%w, operator probably of old version 1.*.*, please upgrade", err) | |||
There was a problem hiding this comment.
Let's not define 1, just old version is enough
pkgs/initiator/requests.go
Outdated
| if parseErr == nil { | ||
| return nil, fmt.Errorf("%v", errmsg) | ||
| } | ||
| return nil, fmt.Errorf("operator failed with: %w, probably of old version 1.*.*, please upgrade", errors.New(string(resdata))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #109 and #106
Old version 0.0.1 and 1.0.1 reply with error
incorrect offsetas they cantsszunmarshal messages structured differently.In case of
pingto older versions even dont havehealth_checkroute, so they reply 404