Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register backends on the fly #538

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Conversation

gordonwatts
Copy link
Collaborator

@gordonwatts gordonwatts commented Jan 1, 2025

This code was designed to enable a local version of SX to run, in process, to help wtih debugging and development.

  • Adds extra object to the Endpoint to track a special adaptor.
  • Ability to register a new end point on the fly, which then gets appended to the list of read end points.
  • ServiceXClient properly creates a specialized client when requested., and one for the minio for_transform.
  • Add ServiceXAdaptor and MinioAdaptor as a protocal.

Notes:

  • pydantic can't seem to deal with duck typing Protocals, so object is getting used.
  • It might be ok to remove the protocol totally - especially if the pydantic problem can't be solved. Or make them sub-classes of a ABC.

@gordonwatts gordonwatts self-assigned this Jan 1, 2025
@gordonwatts gordonwatts added the enhancement New feature or request label Jan 1, 2025
@gordonwatts gordonwatts marked this pull request as draft January 1, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant