Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#508] Use setuptools for plugin mechanism. #509

Open
wants to merge 70 commits into
base: main
Choose a base branch
from

Conversation

tdenewiler
Copy link
Contributor

Switch from yapsy to setuptools for creating plugins for discovery, reporting, and tools.

- Line too long error not reported when upgrading ruff tool from
  0.0.278 to 0.1.1.
- Not running pycodestyle, pydocstyle, isort, or flake8 during tox run.
  Those tools are run in other parts of the Statick testing pipeline.
…r, which are no longer supported by Statick.
@tdenewiler
Copy link
Contributor Author

I am looking for feedback on these changes. Once the changes are agreed to be on the right track, I will open PRs for all the plugin repositories/packages.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c8dd003) to head (cdefe55).

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #509      +/-   ##
===========================================
+ Coverage   99.97%   100.00%   +0.02%     
===========================================
  Files          59        59              
  Lines        3377      3387      +10     
===========================================
+ Hits         3376      3387      +11     
+ Misses          1         0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tdenewiler tdenewiler marked this pull request as ready for review January 3, 2025 03:12
@denewiler denewiler requested review from gregtkogut and xydesa January 3, 2025 17:24
@denewiler denewiler assigned denewiler and tdenewiler and unassigned denewiler Jan 3, 2025
@xydesa
Copy link
Collaborator

xydesa commented Jan 3, 2025

We should do a new minor release before merging this change.

Copy link
Collaborator

@xydesa xydesa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I like the approach, seems pretty clean. Just had some minor comments.

.github/workflows/test.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@tdenewiler
Copy link
Contributor Author

We should do a new minor release before merging this change.

Good idea. That is done now. v0.10.0 released today.

@gregtkogut
Copy link
Collaborator

Great changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants