Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom welding helmet to loadout #1728

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

m-dzianishchyts
Copy link
Collaborator

@m-dzianishchyts m-dzianishchyts commented Jan 4, 2025

Что этот PR делает

Добавляет еще одну маску для сварки, которую мне запретили добавлять на апстриме, потому что она какая-то донатно-персональная. Но мы этим не обременены, так что можно.

Почему это хорошо для игры

Красивая маска за донат.

Тестирование

По аналогии с другими масками, так что верю

Changelog

🆑 Maxiemar
tweak: В лодаут добавлена еще одна сварочная маска с особой раскраской.
/:cl:

Summary by Sourcery

Add a new donor welding helmet with a red flame decal.

New Features:

  • A new cosmetic welding helmet with a red flame decal has been added to the donor loadout.

Tests:

  • Tested by analogy with existing helmets.

Copy link

sourcery-ai bot commented Jan 4, 2025

Reviewer's Guide by Sourcery

This pull request adds a new donor welding helmet with a custom "red flame" decal. It is available to certain engineering and life support roles for a cost of 2 donor points and requires a donor tier of 2.

Class diagram for donor loadout items

classDiagram
    class datum_gear_donor {
        +display_name: string
        +path: string
        +allowed_roles: list
        +donator_tier: number
        +cost: number
    }

    class welding_redflame {
        +display_name: "Red flame decal welding helmet"
        +path: /obj/item/clothing/head/welding/flamedecal
        +allowed_roles: ["Chief Engineer", "Station Engineer", "Life Support Specialist", "Roboticist"]
        +donator_tier: 2
        +cost: 2
    }

    datum_gear_donor <|-- welding_redflame
    note for welding_redflame "New donor welding helmet
with red flame decal"
Loading

File-Level Changes

Change Details Files
Added a new donor welding helmet.
  • A new datum entry /datum/gear/donor/welding_redflame is created.
  • The new helmet has a "red flame" decal.
  • It is set to be available for Chief Engineer, Station Engineer, Life Support Specialist, and Roboticist roles.
  • The helmet requires donor tier 2 and costs 2 donor points.
code/modules/client/preference/loadout/loadout_donor.dm

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions bot added the :finnadie: НЕ МОДУЛЬНО Па-ху-ю. label Jan 4, 2025
@m-dzianishchyts m-dzianishchyts marked this pull request as draft January 5, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant