pythongh-127740: Improve error messages as suggested by @hauntsaninja

srinivasreddy · Dec 10, 2024 · 862bfd5 · 862bfd5
1 parent 7c819c1
commit 862bfd5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Lib/test/test_bytes.py b/Lib/test/test_bytes.py
@@ -460,10 +460,10 @@ def test_fromhex(self):
         self.assertRaises(ValueError, self.type2test.fromhex, '12   \x00   34')
 
         # For odd number of character(s)
-        for value in ("a", "a ", " a"," a ", "aaa", "aaa ", " aaa", " aaa ",  " aa a "):
+        for value in ("a", "a ", " a"," a ", "aaa", "aaa ", " aaa", " aaa "):
             with self.assertRaises(ValueError) as cm:
                 self.type2test.fromhex(value)
-            self.assertIn("fromhex() arg must be of even length", str(cm.exception))
+            self.assertIn("fromhex() arg must contain an even number of hexadecimal digits", str(cm.exception))
 
         for data, pos in (
             # invalid first hexadecimal character

diff --git a/Objects/bytesobject.c b/Objects/bytesobject.c
@@ -2562,7 +2562,7 @@ _PyBytes_FromHex(PyObject *string, int use_bytearray)
   error:
     if (invalid_char == -1) {
         PyErr_SetString(PyExc_ValueError,
-                        "fromhex() arg must be of even length");
+                        "fromhex() arg must contain an even number of hexadecimal digits");
     } else {
         PyErr_Format(PyExc_ValueError,
                      "non-hexadecimal number found in "