prevent setting negative size. Fixes metafizzy#38

negative size causes error in IE
srgsanky · May 14, 2013 · 994d648 · 994d648
1 parent 0546047
commit 994d648
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "packery",
-  "version": "1.0.4",
+  "version": "1.0.5",
   "author": "David DeSandro / Metafizzy",
   "description": "bin-packing layout library",
   "main": [

diff --git a/js/packery.js b/js/packery.js
@@ -1,5 +1,5 @@
 /*!
- * Packery v1.0.4
+ * Packery v1.0.5
  * bin-packing layout library
  * http://packery.metafizzy.co
  *
@@ -357,6 +357,8 @@ Packery.prototype.layoutItems = function( items, isInstant ) {
     elemH += elemSize.paddingBottom + elemSize.paddingTop +
       elemSize.borderTopWidth + elemSize.borderBottomWidth;
   }
+  // prevent negative size, which causes error in IE
+  elemH = Math.max( elemH, 0 );
   this.element.style.height = elemH + 'px';
 };
 

diff --git a/test/defaults-empty.js b/test/defaults-empty.js
@@ -18,6 +18,8 @@ test( 'defaults / empty', function() {
     return true; // bind once
   });
   stop();
+  // add gutter, to check that container size doesn't get negative number
+  pckry.options.gutter = 20;
   pckry.layout();
 });