Partially reverted b2a9ac5 - missing last_reset #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As last_reset is missing from solax daily_totals in ha-core integration, b2a9ac5 needed to be partially reversed as it makes consumed and fed in daily totals unusable. - reverted consumed and feed in daily total to Total class
|
On top of that, I think we should move all those Daily reset (resulting in "broken" I can do the legwork @squishykid , but I'd appreciate having some discussion with people knowing the environment better :) |
darmach
force-pushed
the
partial-revert-x3-hybrid-g4
branch
from
3369e89 to
2cccfca
Compare
|
Could you take a look on this revert @squishykid ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @squishykid I'm afraid I need to partially revert that recent change...
As last_reset is missing from solax daily_totals in ha-core integration, b2a9ac5 needed to be partially reversed as it makes consumed and fed in daily totals unusable.
I still think that these should be[1], however right now, asDailyTotalDailyTotalthey end up being simplemeasurementwithoutlast_resetset - and this makes them unusable in energy dashboard, even breaking it completely - to the point when user is no longer able to reconfigure it to remove them.This should be fixed by home-assistant/core#114743 which was closed for now by @frenck as it got stale...
Fix for the previously mentioned energy dashboard issue is to set their
state_classin HA developer tools back tototal_increasingand quickly enter edit mode of energy dashboard to delete them from configuration.[1] https://developers.home-assistant.io/blog/2021/08/16/state_class_total/ - in this context measuremednt for a daily reset total sensor is no longer valid, and we should switch to total increasing.