-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
X3 Hybrid G4: Attributes added #136
Conversation
add Battery mode
Battery Remaining Energy added
Feed-in und Consumed Energy total added
EPS Energy total / today added
PV Energy total added
Battery (Dis-)charge Energy total/today added
Load/Generator Power added
EPS Current and Voltage Units fixed
Battery Voltage and Current added
import twoway_div100
rename Feed-in -> Grid Power
Can you please pull in master? Then we can run the tests |
I tried to. Is ok now? It is still squishykid:master. I cannot choose any other. |
You have the PR all correct :) To clarify, I mean that you need to update your branch by 'pulling in' all the changes from upstream's master (squishykid/solax repo [this repo]). These changes include new testing infrastructure. There's a guide here: https://www.atlassian.com/git/tutorials/git-forks-and-upstreams. You will need to set this repo (squishykid/solax) as the 'upstream'. |
There's also another set of instructions here: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork#syncing-a-fork-branch-from-the-command-line Under the section "Syncing a fork branch from the command line" |
…he data. Field 169, 170 probably better than 39.
refactor battery_modes to _decode_battery_mode
using the right comment method (hopefully)
added test values for X3_HYBRID_G4
added missing comma
removed duplicate value
added test value 'PV Energy total'
adjust expectred values with example response
@squishykid finally, all test are fine. |
Nice work. Now you can raise a PR against home-assistant to bump the solax package to v3.0.5. Then your changes will be included in the next release! |
Content:
Open:
refs #80